<div dir="ltr">It's on the Phab issue, but for some reason Phab isn't sending out emails. You can view it there, but I'll go ahead and attach it here anyway.<div><br></div><div><br></div></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Tue, Jun 10, 2014 at 12:56 PM, Alp Toker <span dir="ltr"><<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class=""><br>
On 10/06/2014 22:46, Zachary Turner wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Maybe a bug in Phabricator, but for some reason email notifications for this particular issue are no longer being sent out. So I'm responding here since changes a new revision has been uploaded:<br>
<br>
Most recent summary:<br>
1) All major review issues addressed<br>
2) rnk@ spoke to someone from Apple who said their biggest concern is whether it will have any impact on single-threaded compilation performance.<br>
3) Ran tests on MacOSX by compiling sqlite3.c with / without the patch, and saw no noticeable impact on performance, which hopefully satisfies the concern raised in #2<br>
4) Change was discussed on LLVMDev prior to initial upload to Phabricator, so some support has been built for this already. If anyone feels like more is necessary before committing, please speak up.<br>
</blockquote>
<br></div>
Patch?<span class="HOEnZb"><font color="#888888"><br>
<br>
Alp.<br>
<br>
<br>
</font></span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">
<br>
<br>
On Mon, Jun 9, 2014 at 4:27 PM, Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a> <mailto:<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>>> wrote:<br>
<br>
Address review comments.<br>
<br>
<a href="http://reviews.llvm.org/D4076" target="_blank">http://reviews.llvm.org/D4076</a><br>
<br>
Files:<br>
include/llvm-c/Core.h<br>
include/llvm/Support/<u></u>ManagedStatic.h<br>
include/llvm/Support/<u></u>Threading.h<br>
lib/IR/Core.cpp<br>
lib/Support/ErrorHandling.cpp<br>
lib/Support/ManagedStatic.cpp<br>
lib/Support/Threading.cpp<br>
lib/Support/Timer.cpp<br>
<br>
<br>
<br>
<br></div><div class="">
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</div></blockquote><div class="HOEnZb"><div class="h5">
<br>
-- <br>
<a href="http://www.nuanti.com" target="_blank">http://www.nuanti.com</a><br>
the browser experts<br>
<br>
</div></div></blockquote></div><br></div>