<div dir="ltr">Ah that explains why. I'll update the LLVM tree and try this again, and re-submit your commit. Sorry for the confusion.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jun 9, 2014 at 1:50 AM, Simon Atanasyan <span dir="ltr"><<a href="mailto:simon@atanasyan.com" target="_blank">simon@atanasyan.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hmm, that is rather strange because I committed Visibility tag support<br>
a few days ago at r210316<br>
(<a href="http://llvm.org/viewvc/llvm-project?rev=210316&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=210316&view=rev</a>). Did you<br>
update yaml2obj source code?<br>
<div class="HOEnZb"><div class="h5"><br>
On Mon, Jun 9, 2014 at 12:31 PM, Rui Ueyama <<a href="mailto:ruiu@google.com">ruiu@google.com</a>> wrote:<br>
> The test added in this patch contains a YAML directive that cannot be parsed<br>
> by LLD. Did you forget to commit a change for "Visibility"? I'll revert this<br>
> commit to make the build green.<br>
><br>
> yaml2obj -format=elf /home/ruiu/llvm/tools/lld/test/elf/Mips/got16.test ><br>
> /home/ruiu/build/tools/lld/test/elf/Mips/Output/got16.test.tmp.o<br>
> lld -flavor gnu -target mipsel -shared --noinhibit-exec<br>
> --output-filetype=yaml<br>
> /home/ruiu/build/tools/lld/test/elf/Mips/Output/got16.test.tmp.o |<br>
> FileCheck -check-prefix YAML<br>
> /home/ruiu/llvm/tools/lld/test/elf/Mips/got16.test<br>
> lld -flavor gnu -target mipsel -shared --noinhibit-exec -o<br>
> /home/ruiu/build/tools/lld/test/elf/Mips/Output/got16.test.tmp2<br>
> /home/ruiu/build/tools/lld/test/elf/Mips/Output/got16.test.tmp.o<br>
> llvm-objdump -t -disassemble<br>
> /home/ruiu/build/tools/lld/test/elf/Mips/Output/got16.test.tmp2 | FileCheck<br>
> -check-prefix RAW /home/ruiu/llvm/tools/lld/test/elf/Mips/got16.test<br>
> --<br>
> Exit Code: 1<br>
><br>
> Command Output (stderr):<br>
> --<br>
> YAML:195:24: error: unknown key 'Visibility'<br>
> Visibility: STV_HIDDEN<br>
> ^~~~~~~~~~<br>
> yaml2obj: Failed to parse YAML file!<br>
><br>
><br>
><br>
> On Sun, Jun 8, 2014 at 4:33 AM, Simon Atanasyan <<a href="mailto:simon@atanasyan.com">simon@atanasyan.com</a>> wrote:<br>
>><br>
>> Author: atanasyan<br>
>> Date: Sun Jun 8 06:33:05 2014<br>
>> New Revision: 210425<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=210425&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=210425&view=rev</a><br>
>> Log:<br>
>> [Mips] Make got16.test test case independent from external input files.<br>
>><br>
>> Removed:<br>
>> lld/trunk/test/elf/Mips/Inputs/got16.o<br>
>> Modified:<br>
>> lld/trunk/test/elf/Mips/got16.test<br>
>><br>
>> Removed: lld/trunk/test/elf/Mips/Inputs/got16.o<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/elf/Mips/Inputs/got16.o?rev=210424&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/test/elf/Mips/Inputs/got16.o?rev=210424&view=auto</a><br>
>><br>
>> ==============================================================================<br>
>> Binary files lld/trunk/test/elf/Mips/Inputs/got16.o (original) and<br>
>> lld/trunk/test/elf/Mips/Inputs/got16.o (removed) differ<br>
>><br>
>> Modified: lld/trunk/test/elf/Mips/got16.test<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/elf/Mips/got16.test?rev=210425&r1=210424&r2=210425&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/test/elf/Mips/got16.test?rev=210425&r1=210424&r2=210425&view=diff</a><br>
>><br>
>> ==============================================================================<br>
>> --- lld/trunk/test/elf/Mips/got16.test (original)<br>
>> +++ lld/trunk/test/elf/Mips/got16.test Sun Jun 8 06:33:05 2014<br>
>> @@ -1,11 +1,11 @@<br>
>> # REQUIRES: mips<br>
>><br>
>> # Check handling of global/local GOT16 relocations.<br>
>> +# RUN: yaml2obj -format=elf %s > %t.o<br>
>> # RUN: lld -flavor gnu -target mipsel -shared --noinhibit-exec \<br>
>> -# RUN: --output-filetype=yaml %S/Inputs/got16.o \<br>
>> +# RUN: --output-filetype=yaml %t.o \<br>
>> # RUN: | FileCheck -check-prefix YAML %s<br>
>> -# RUN: lld -flavor gnu -target mipsel -shared --noinhibit-exec -o %t2 \<br>
>> -# RUN: %S/Inputs/got16.o<br>
>> +# RUN: lld -flavor gnu -target mipsel -shared --noinhibit-exec -o %t2<br>
>> %t.o<br>
>> # RUN: llvm-objdump -t -disassemble %t2 | FileCheck -check-prefix RAW %s<br>
>><br>
>> # Local GOT entries:<br>
>> @@ -119,3 +119,78 @@<br>
>> # RAW: 00012200 l .data 00000005 str2<br>
>> # RAW: 0000012c g F .text 0000001c glob<br>
>> # RAW: 00012205 g .data 00000004 hidden<br>
>> +<br>
>> +---<br>
>> +FileHeader:<br>
>> + Class: ELFCLASS32<br>
>> + Data: ELFDATA2LSB<br>
>> + Type: ET_REL<br>
>> + Machine: EM_MIPS<br>
>> + Flags: [ EF_MIPS_ABI_O32, EF_MIPS_ARCH_32 ]<br>
>> +<br>
>> +Sections:<br>
>> + - Name: .text<br>
>> + Type: SHT_PROGBITS<br>
>> + Flags: [ SHF_ALLOC, SHF_EXECINSTR ]<br>
>> + AddressAlign: 0x04<br>
>> + Content:<br>
>> '0000848F000084240100848F000284240000848F0000848F0000848F'<br>
>> + - Name: .rel.text<br>
>> + Type: SHT_REL<br>
>> + Link: .symtab<br>
>> + AddressAlign: 0x04<br>
>> + Info: .text<br>
>> + Relocations:<br>
>> + - Offset: 0x00<br>
>> + Symbol: .data<br>
>> + Type: R_MIPS_GOT16<br>
>> + - Offset: 0x04<br>
>> + Symbol: .data<br>
>> + Type: R_MIPS_LO16<br>
>> + - Offset: 0x08<br>
>> + Symbol: .data<br>
>> + Type: R_MIPS_GOT16<br>
>> + - Offset: 0x0C<br>
>> + Symbol: .data<br>
>> + Type: R_MIPS_LO16<br>
>> + - Offset: 0x10<br>
>> + Symbol: hidden<br>
>> + Type: R_MIPS_GOT16<br>
>> + - Offset: 0x14<br>
>> + Symbol: glob<br>
>> + Type: R_MIPS_CALL16<br>
>> + - Offset: 0x18<br>
>> + Symbol: extern<br>
>> + Type: R_MIPS_CALL16<br>
>> + - Name: .data<br>
>> + Type: SHT_PROGBITS<br>
>> + Flags: [ SHF_WRITE, SHF_ALLOC ]<br>
>> + AddressAlign: 0x04<br>
>> + Size: 0x10209<br>
>> +<br>
>> +Symbols:<br>
>> + Local:<br>
>> + - Name: str1<br>
>> + Type: STT_OBJECT<br>
>> + Section: .data<br>
>> + Size: 0x10200<br>
>> + - Name: str2<br>
>> + Type: STT_OBJECT<br>
>> + Section: .data<br>
>> + Value: 0x10200<br>
>> + Size: 0x05<br>
>> + - Name: .text<br>
>> + Type: STT_SECTION<br>
>> + Section: .text<br>
>> + - Name: .data<br>
>> + Type: STT_SECTION<br>
>> + Section: .data<br>
>> + Global:<br>
>> + - Name: glob<br>
>> + Section: .text<br>
>> + - Name: hidden<br>
>> + Type: STT_OBJECT<br>
>> + Section: .data<br>
>> + Value: 0x10205<br>
>> + Size: 0x04<br>
>> + Visibility: STV_HIDDEN<br>
>> + - Name: extern<br>
>><br>
>><br>
>> _______________________________________________<br>
>> llvm-commits mailing list<br>
>> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
><br>
<br>
<br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Simon Atanasyan<br>
</font></span></blockquote></div><br></div>