<div dir="ltr">It may just be me, but I think it's a lot of noise for no real gain to try to remove these comments eagerly. I would just remove them from code you're actively planning to modify.</div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Fri, Jun 6, 2014 at 6:21 PM, Sean Silva <span dir="ltr"><<a href="mailto:chisophugis@gmail.com" target="_blank">chisophugis@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div>An enormous number of classof's have a copypasted comment above them like this. Are you planning on removing them too?<br><br>I was about to suggest to standardize on a copypasted comment that will lead them to <a href="http://llvm.org/docs/HowToSetUpLLVMStyleRTTI.html" target="_blank">http://llvm.org/docs/HowToSetUpLLVMStyleRTTI.html</a>, but it turns out that that page is already the top result for `llvm classof`. Back when I got started with LLVM `llvm classof` just turned up a bunch of doxygen pages and I remember it taking me a while to figure it out...<span class="HOEnZb"><font color="#888888"><br>
<br></font></span></div><span class="HOEnZb"><font color="#888888">-- Sean Silva<br></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jun 3, 2014 at 1:06 PM, Alp Toker <span dir="ltr"><<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: alp<br>
Date: Tue Jun 3 14:06:49 2014<br>
New Revision: 210118<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=210118&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=210118&view=rev</a><br>
Log:<br>
Remove some redundant doc comments<br>
<br>
Modified:<br>
llvm/trunk/include/llvm/IR/DiagnosticInfo.h<br>
<br>
Modified: llvm/trunk/include/llvm/IR/DiagnosticInfo.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/DiagnosticInfo.h?rev=210118&r1=210117&r2=210118&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/DiagnosticInfo.h?rev=210118&r1=210117&r2=210118&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/IR/DiagnosticInfo.h (original)<br>
+++ llvm/trunk/include/llvm/IR/DiagnosticInfo.h Tue Jun 3 14:06:49 2014<br>
@@ -138,7 +138,6 @@ public:<br>
/// \see DiagnosticInfo::print.<br>
void print(DiagnosticPrinter &DP) const override;<br>
<br>
- /// Hand rolled RTTI.<br>
static bool classof(const DiagnosticInfo *DI) {<br>
return DI->getKind() == DK_InlineAsm;<br>
}<br>
@@ -166,7 +165,6 @@ public:<br>
/// \see DiagnosticInfo::print.<br>
void print(DiagnosticPrinter &DP) const override;<br>
<br>
- /// Hand rolled RTTI.<br>
static bool classof(const DiagnosticInfo *DI) {<br>
return DI->getKind() == DK_StackSize;<br>
}<br>
@@ -195,7 +193,6 @@ public:<br>
/// \see DiagnosticInfo::print.<br>
void print(DiagnosticPrinter &DP) const override;<br>
<br>
- /// Hand rolled RTTI.<br>
static bool classof(const DiagnosticInfo *DI) {<br>
return DI->getKind() == DK_DebugMetadataVersion;<br>
}<br>
@@ -221,7 +218,6 @@ public:<br>
/// \see DiagnosticInfo::print.<br>
void print(DiagnosticPrinter &DP) const override;<br>
<br>
- /// Hand rolled RTTI.<br>
static bool classof(const DiagnosticInfo *DI) {<br>
return DI->getKind() == DK_SampleProfile;<br>
}<br>
@@ -261,7 +257,6 @@ public:<br>
/// \see DiagnosticInfo::print.<br>
void print(DiagnosticPrinter &DP) const override;<br>
<br>
- /// Hand rolled RTTI.<br>
static bool classof(const DiagnosticInfo *DI) {<br>
return DI->getKind() == DK_OptimizationRemark;<br>
}<br>
@@ -323,7 +318,6 @@ public:<br>
: DiagnosticInfoOptimizationRemarkBase(DK_OptimizationRemark, PassName,<br>
Fn, DLoc, Msg) {}<br>
<br>
- /// Hand rolled RTTI<br>
static bool classof(const DiagnosticInfo *DI) {<br>
return DI->getKind() == DK_OptimizationRemark;<br>
}<br>
@@ -350,7 +344,6 @@ public:<br>
: DiagnosticInfoOptimizationRemarkBase(DK_OptimizationRemarkMissed,<br>
PassName, Fn, DLoc, Msg) {}<br>
<br>
- /// Hand rolled RTTI<br>
static bool classof(const DiagnosticInfo *DI) {<br>
return DI->getKind() == DK_OptimizationRemarkMissed;<br>
}<br>
@@ -378,7 +371,6 @@ public:<br>
: DiagnosticInfoOptimizationRemarkBase(DK_OptimizationRemarkAnalysis,<br>
PassName, Fn, DLoc, Msg) {}<br>
<br>
- /// Hand rolled RTTI<br>
static bool classof(const DiagnosticInfo *DI) {<br>
return DI->getKind() == DK_OptimizationRemarkAnalysis;<br>
}<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>