<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jun 6, 2014 at 7:29 PM, Alp Toker <span dir="ltr"><<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class=""><br>
On 07/06/2014 04:21, Sean Silva wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
An enormous number of classof's have a copypasted comment above them like this. Are you planning on removing them too?<br>
</blockquote>
<br></div>
I guess we can go ahead and do it. I have the regex handy but in this instance I only took out the ones that were getting the way.<div class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
I was about to suggest to standardize on a copypasted comment that will lead them to <a href="http://llvm.org/docs/HowToSetUpLLVMStyleRTTI.html" target="_blank">http://llvm.org/docs/<u></u>HowToSetUpLLVMStyleRTTI.html</a>, but it turns out that that page is already the top result for `llvm classof`. Back when I got started with LLVM `llvm classof` just turned up a bunch of doxygen pages and I remember it taking me a while to figure it out...<br>
</blockquote>
<br></div>
Right, by now it's a fairly engrained and discoverable pattern. Given the brevity of most of the classof inline functions, the comments end up almost doubling the line count in places which irks me. What do you think?<br>
</blockquote><div><br></div><div>I think I'll just defer to Chandler's preference here. So I guess for now we'll leave them in.<br><br></div><div>-- Sean Silva<br> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Alp.<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
-- Sean Silva<div><div class="h5"><br>
<br>
<br>
On Tue, Jun 3, 2014 at 1:06 PM, Alp Toker <<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a> <mailto:<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>>> wrote:<br>
<br>
Author: alp<br>
Date: Tue Jun 3 14:06:49 2014<br>
New Revision: 210118<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=210118&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=210118&view=rev</a><br>
Log:<br>
Remove some redundant doc comments<br>
<br>
Modified:<br>
llvm/trunk/include/llvm/IR/<u></u>DiagnosticInfo.h<br>
<br>
Modified: llvm/trunk/include/llvm/IR/<u></u>DiagnosticInfo.h<br>
URL:<br>
<a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/DiagnosticInfo.h?rev=210118&r1=210117&r2=210118&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/include/<u></u>llvm/IR/DiagnosticInfo.h?rev=<u></u>210118&r1=210117&r2=210118&<u></u>view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/include/llvm/IR/<u></u>DiagnosticInfo.h (original)<br>
+++ llvm/trunk/include/llvm/IR/<u></u>DiagnosticInfo.h Tue Jun 3<br>
14:06:49 2014<br>
@@ -138,7 +138,6 @@ public:<br>
/// \see DiagnosticInfo::print.<br>
void print(DiagnosticPrinter &DP) const override;<br>
<br>
- /// Hand rolled RTTI.<br>
static bool classof(const DiagnosticInfo *DI) {<br>
return DI->getKind() == DK_InlineAsm;<br>
}<br>
@@ -166,7 +165,6 @@ public:<br>
/// \see DiagnosticInfo::print.<br>
void print(DiagnosticPrinter &DP) const override;<br>
<br>
- /// Hand rolled RTTI.<br>
static bool classof(const DiagnosticInfo *DI) {<br>
return DI->getKind() == DK_StackSize;<br>
}<br>
@@ -195,7 +193,6 @@ public:<br>
/// \see DiagnosticInfo::print.<br>
void print(DiagnosticPrinter &DP) const override;<br>
<br>
- /// Hand rolled RTTI.<br>
static bool classof(const DiagnosticInfo *DI) {<br>
return DI->getKind() == DK_DebugMetadataVersion;<br>
}<br>
@@ -221,7 +218,6 @@ public:<br>
/// \see DiagnosticInfo::print.<br>
void print(DiagnosticPrinter &DP) const override;<br>
<br>
- /// Hand rolled RTTI.<br>
static bool classof(const DiagnosticInfo *DI) {<br>
return DI->getKind() == DK_SampleProfile;<br>
}<br>
@@ -261,7 +257,6 @@ public:<br>
/// \see DiagnosticInfo::print.<br>
void print(DiagnosticPrinter &DP) const override;<br>
<br>
- /// Hand rolled RTTI.<br>
static bool classof(const DiagnosticInfo *DI) {<br>
return DI->getKind() == DK_OptimizationRemark;<br>
}<br>
@@ -323,7 +318,6 @@ public:<br>
:<br>
DiagnosticInfoOptimizationRema<u></u>rkBase(DK_OptimizationRemark, PassName,<br>
Fn, DLoc, Msg) {}<br>
<br>
- /// Hand rolled RTTI<br>
static bool classof(const DiagnosticInfo *DI) {<br>
return DI->getKind() == DK_OptimizationRemark;<br>
}<br>
@@ -350,7 +344,6 @@ public:<br>
:<br>
DiagnosticInfoOptimizationRema<u></u>rkBase(DK_<u></u>OptimizationRemarkMissed,<br>
PassName, Fn, DLoc,<br>
Msg) {}<br>
<br>
- /// Hand rolled RTTI<br>
static bool classof(const DiagnosticInfo *DI) {<br>
return DI->getKind() == DK_OptimizationRemarkMissed;<br>
}<br>
@@ -378,7 +371,6 @@ public:<br>
:<br>
DiagnosticInfoOptimizationRema<u></u>rkBase(DK_<u></u>OptimizationRemarkAnalysis,<br>
PassName, Fn, DLoc,<br>
Msg) {}<br>
<br>
- /// Hand rolled RTTI<br>
static bool classof(const DiagnosticInfo *DI) {<br>
return DI->getKind() == DK_OptimizationRemarkAnalysis;<br>
}<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br></div></div>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a> <mailto:<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.<u></u>edu</a>><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
<br>
<br><span class="HOEnZb"><font color="#888888">
</font></span></blockquote><span class="HOEnZb"><font color="#888888">
<br>
-- <br>
<a href="http://www.nuanti.com" target="_blank">http://www.nuanti.com</a><br>
the browser experts<br>
<br>
</font></span></blockquote></div><br></div></div>