<div dir="ltr">Seems good for LLVM IL consistency, but what does it mean to export an unnamed global?  Now I want a test for the error that we should produce somewhere when running llc on this.  :)</div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Tue, Jun 3, 2014 at 1:07 PM, Rafael Espindola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: rafael<br>
Date: Tue Jun  3 15:07:32 2014<br>
New Revision: 210121<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=210121&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=210121&view=rev</a><br>
Log:<br>
Fix a small bug in the parsing of anonymous globals.<br>
<br>
It was able to parse<br>
<br>
hidden dllexport global i32 42<br>
<br>
but not<br>
<br>
dllexport global i32 42<br>
<br>
Modified:<br>
    llvm/trunk/lib/AsmParser/LLParser.cpp<br>
    llvm/trunk/test/Feature/globalvars.ll<br>
<br>
Modified: llvm/trunk/lib/AsmParser/LLParser.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/AsmParser/LLParser.cpp?rev=210121&r1=210120&r2=210121&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/AsmParser/LLParser.cpp?rev=210121&r1=210120&r2=210121&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/AsmParser/LLParser.cpp (original)<br>
+++ llvm/trunk/lib/AsmParser/LLParser.cpp Tue Jun  3 15:07:32 2014<br>
@@ -261,6 +261,8 @@ bool LLParser::ParseTopLevelEntities() {<br>
     case lltok::kw_default:             // OptionalVisibility<br>
     case lltok::kw_hidden:              // OptionalVisibility<br>
     case lltok::kw_protected:           // OptionalVisibility<br>
+    case lltok::kw_dllimport:           // OptionalDLLStorageClass<br>
+    case lltok::kw_dllexport:           // OptionalDLLStorageClass<br>
     case lltok::kw_thread_local:        // OptionalThreadLocal<br>
     case lltok::kw_addrspace:           // OptionalAddrSpace<br>
     case lltok::kw_constant:            // GlobalType<br>
<br>
Modified: llvm/trunk/test/Feature/globalvars.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Feature/globalvars.ll?rev=210121&r1=210120&r2=210121&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Feature/globalvars.ll?rev=210121&r1=210120&r2=210121&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/test/Feature/globalvars.ll (original)<br>
+++ llvm/trunk/test/Feature/globalvars.ll Tue Jun  3 15:07:32 2014<br>
@@ -16,3 +16,5 @@ define i32 @foo(i32 %blah) {<br>
         ret i32 %blah<br>
 }<br>
<br>
+hidden dllexport global i32 42<br>
+dllexport global i32 42<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>