<div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif">Karthik, I do not have any objections to this patch. I think longer term we should try to pursue the other cases but this is a good short-term step.</div>
<div class="gmail_default" style="font-family:verdana,sans-serif"><br></div><div class="gmail_default" style="font-family:verdana,sans-serif">I'll let others provide their approval.</div></div><div class="gmail_extra">
<br clear="all"><div><div dir="ltr"><div><div style="line-height:1.5em;padding-top:10px;margin-top:10px;font-family:sans-serif;font-size:small"><span style="color:rgb(85,85,85);border-width:2px 0px 0px;border-style:solid;border-color:rgb(213,15,37);padding-top:2px;margin-top:2px">Raúl E Silvera |</span><span style="color:rgb(85,85,85);border-width:2px 0px 0px;border-style:solid;border-color:rgb(51,105,232);padding-top:2px;margin-top:2px"> SWE |</span><span style="color:rgb(85,85,85);border-width:2px 0px 0px;border-style:solid;border-color:rgb(0,153,57);padding-top:2px;margin-top:2px"> <a href="mailto:rsilvera@google.com" target="_blank">rsilvera@google.com</a> |</span><span style="border-width:2px 0px 0px;border-style:solid;border-color:rgb(238,178,17);padding-top:2px;margin-top:2px"><font color="#555555"> </font><font color="#0033bb"><u>408-789-2846</u></font></span></div>
<br></div></div></div>
<br><br><div class="gmail_quote">On Tue, May 27, 2014 at 9:12 PM, Karthik Bhat <span dir="ltr"><<a href="mailto:kv.bhat@samsung.com" target="_blank">kv.bhat@samsung.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Nadav,<br>
Please find the performance result with and without patch. I dont see large regression in compilation time though execution time of one test case improved greatly. The baseline is without patch and current is with patch.<br>
<br>
{F60858}<br>
<br>
Hi Raul,Arnold<br>
I agree that the current patch will not handle the case mentioned. I was thinking of handling unschedulable loads again after buildTree_rec was completed but as arnold mentioned i'm not sure if this would be worth the ovehead.<br>
<br>
For now do you think we can move ahead with this approach as we are able to vectorize loads similar to one's mentioned in the PR without much overhead?<br>
<br>
Thanks for all the comments and review.<br>
<div class="HOEnZb"><div class="h5"><br>
Regards<br>
Karthik Bhat<br>
<br>
<a href="http://reviews.llvm.org/D3800" target="_blank">http://reviews.llvm.org/D3800</a><br>
<br>
<br>
</div></div></blockquote></div><br></div>