<div dir="ltr">This assertion still fires on sanitizer buildbot: <a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/9775/steps/run%20sanitizer%20tests%20in%20gcc%20build/logs/stdio">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/9775/steps/run%20sanitizer%20tests%20in%20gcc%20build/logs/stdio</a></div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, May 20, 2014 at 11:36 AM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dblaikie<br>
Date: Tue May 20 13:36:35 2014<br>
New Revision: 209226<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=209226&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=209226&view=rev</a><br>
Log:<br>
Fix test breakage introduced in r209223.<br>
<br>
Oops, broke the broken enum constants again.<br>
<br>
Modified:<br>
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp<br>
<br>
Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp?rev=209226&r1=209225&r2=209226&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp?rev=209226&r1=209225&r2=209226&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp Tue May 20 13:36:35 2014<br>
@@ -759,7 +759,8 @@ static bool isUnsignedDIType(DwarfDebug<br>
       return true;<br>
     assert(T == dwarf::DW_TAG_typedef || T == dwarf::DW_TAG_const_type ||<br>
            T == dwarf::DW_TAG_volatile_type ||<br>
-           T == dwarf::DW_TAG_restrict_type);<br>
+           T == dwarf::DW_TAG_restrict_type ||<br>
+           T == dwarf::DW_TAG_enumeration_type);<br>
     if (DITypeRef Deriv = DTy.getTypeDerivedFrom())<br>
       return isUnsignedDIType(DD, DD->resolve(Deriv));<br>
     // FIXME: Enums without a fixed underlying type have unknown signedness<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><div>Alexey Samsonov, Mountain View, CA</div></div>
</div>