<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 16 May 2014 01:46, David Majnemer <span dir="ltr"><<a href="mailto:david.majnemer@gmail.com" target="_blank">david.majnemer@gmail.com</a>></span> wrote:<br>

</div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Address review comments.<br></blockquote><div><br></div><div>LG</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<div class="">
<a href="http://reviews.llvm.org/D3795" target="_blank">http://reviews.llvm.org/D3795</a><br>
<br>
Files:<br>
  lib/Analysis/InstructionSimplify.cpp<br>
  test/Transforms/InstSimplify/compare.ll<br>
<br>
Index: lib/Analysis/InstructionSimplify.cpp<br>
===================================================================<br>
--- lib/Analysis/InstructionSimplify.cpp<br>
+++ lib/Analysis/InstructionSimplify.cpp<br>
@@ -2020,6 +2020,10 @@<br>
       APInt NegOne = APInt::getAllOnesValue(Width);<br>
       if (!CI2->isZero())<br>
         Upper = NegOne.udiv(CI2->getValue()) + 1;<br>
+    } else if (match(LHS, m_SDiv(m_ConstantInt(CI2), m_Value()))) {<br>
+      // 'sdiv CI2, x' produces [-|CI2|, |CI2|].<br>
</div>+      Upper = CI2->getValue().abs() + 1;<br>
<div class="HOEnZb"><div class="h5">+      Lower = (-Upper) + 1;<br>
     } else if (match(LHS, m_SDiv(m_Value(), m_ConstantInt(CI2)))) {<br>
       // 'sdiv x, CI2' produces [INT_MIN / CI2, INT_MAX / CI2].<br>
       APInt IntMin = APInt::getSignedMinValue(Width);<br>
Index: test/Transforms/InstSimplify/compare.ll<br>
===================================================================<br>
--- test/Transforms/InstSimplify/compare.ll<br>
+++ test/Transforms/InstSimplify/compare.ll<br>
@@ -817,3 +817,12 @@<br>
 ; CHECK-LABEL: @compare_always_false_ne<br>
 ; CHECK-NEXT: ret i1 true<br>
 }<br>
+<br>
+define i1 @compare_dividend(i32 %a) {<br>
+  %div = sdiv i32 2, %a<br>
+  %cmp = icmp eq i32 %div, 3<br>
+  ret i1 %cmp<br>
+<br>
+; CHECK-LABEL: @compare_dividend<br>
+; CHECK-NEXT: ret i1 false<br>
+}<br>
</div></div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div></div></div>