<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Patch LGTM.<div><br><div style=""><div>On May 16, 2014, at 10:46 AM, Hal Finkel <<a href="mailto:hfinkel@anl.gov">hfinkel@anl.gov</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">----- Original Message -----<br><blockquote type="cite">From: "Chris Matthews" <<a href="mailto:chris.matthews@apple.com">chris.matthews@apple.com</a>><br>To: "Hal Finkel" <<a href="mailto:hfinkel@anl.gov">hfinkel@anl.gov</a>><br>Cc: "Yi Kong" <<a href="mailto:kongy.dev@gmail.com">kongy.dev@gmail.com</a>>,<span class="Apple-converted-space"> </span><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>, "Anton Korobeynikov" <<a href="mailto:anton@korobeynikov.info">anton@korobeynikov.info</a>><br>Sent: Friday, May 16, 2014 12:42:47 PM<br>Subject: Re: [PATCH] [LNT] Add geometric mean to run report<br><br>I wonder if we filter, if benchmarks that move around the filter<br>point, so that sometimes they are included, and other times not,<br>would cause problems in the geomean?<br></blockquote><br>I'm not sure that it would cause too much of a problem; on the other hand, Yi's proposal to add 1 to everything (and subtract it at the end) might be the most numerically-stable adjustment.<br><br>-Hal<br><br><blockquote type="cite"><br><br>On May 16, 2014, at 10:39 AM, Chris Matthews<br><<a href="mailto:chris.matthews@apple.com">chris.matthews@apple.com</a>> wrote:<br><br><blockquote type="cite">I agree that it would be better to filter them in some way.<br><br>I really like the idea of trying this though.<br><br>On May 16, 2014, at 10:37 AM, Hal Finkel <<a href="mailto:hfinkel@anl.gov">hfinkel@anl.gov</a>> wrote:<br><br><blockquote type="cite">----- Original Message -----<br><blockquote type="cite">From: "Hal Finkel" <<a href="mailto:hfinkel@anl.gov">hfinkel@anl.gov</a>><br>To: "Yi Kong" <<a href="mailto:kongy.dev@gmail.com">kongy.dev@gmail.com</a>><br>Cc: <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>, "Chris Matthews"<br><<a href="mailto:chris.matthews@apple.com">chris.matthews@apple.com</a>>, "Anton Korobeynikov"<br><<a href="mailto:anton@korobeynikov.info">anton@korobeynikov.info</a>><br>Sent: Friday, May 16, 2014 12:29:21 PM<br>Subject: Re: [PATCH] [LNT] Add geometric mean to run report<br><br>----- Original Message -----<br><blockquote type="cite">From: "Yi Kong" <<a href="mailto:kongy.dev@gmail.com">kongy.dev@gmail.com</a>><br>To: "Chris Matthews" <<a href="mailto:chris.matthews@apple.com">chris.matthews@apple.com</a>>, "Anton<br>Korobeynikov" <<a href="mailto:anton@korobeynikov.info">anton@korobeynikov.info</a>><br>Cc: <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>Sent: Friday, May 16, 2014 12:08:54 PM<br>Subject: [PATCH] [LNT] Add geometric mean to run report<br><br>Hi all,<br><br>This patch implements geometric mean in run report.<br></blockquote><br>You mean that this is for all tests in the entire test suite<br>aggregated into a single number?<br><br><blockquote type="cite"><br>The idea of geomean is to represent the entire data set and not<br>to<br>get<br>skewed by long running tests. However the major problem with it<br>is,<br>zero time is not allowed. I used a workaround by adding 1 to<br>each<br>value and subtract 1 from the final geomean result. The<br>workaround<br>certainly break the geomean number, but we don't really care the<br>number itself, rather the change of it. It's certainly not the<br>ideal.<br>Is there any better solution or statistics we can use?<br></blockquote><br>I don't understand this at all. Is the geometric mean not<br>(mul_i^n<br>a_i)^(1/n)?<br></blockquote><br>On the other hand, I suppose if you include any zeros, then the<br>answer is always zero. Why don't you just exclude values less<br>than 0.1s? Maybe this is no better than what you've proposed.<br><br>-Hal<br><br><blockquote type="cite"><br>Thanks again,<br>Hal<br><br><blockquote type="cite"><br>Thanks,<br>Yi Kong<br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br><br></blockquote><br>--<br>Hal Finkel<br>Assistant Computational Scientist<br>Leadership Computing Facility<br>Argonne National Laboratory<br><br></blockquote><br>--<br>Hal Finkel<br>Assistant Computational Scientist<br>Leadership Computing Facility<br>Argonne National Laboratory<br></blockquote><br></blockquote><br><br></blockquote><br>--<span class="Apple-converted-space"> </span><br>Hal Finkel<br>Assistant Computational Scientist<br>Leadership Computing Facility<br>Argonne National Laboratory</div></blockquote></div><br></div></body></html>