<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Alternatively, we can remove %run from all the tests and use the following regular expression to match when a test is attempting to run an executable. r'(?<!-o )(%t)(?!\.)' This uses negative lookbehind to ensure the test is not creating the executable and negative lookahead to ensure it is an executable and not an object file or shared object.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>A drawback is that tests must have executable names with no file extension, and likewise non-executables must have an extension. Currently, that’s coincidently the case.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Thoughts?<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>-Greg<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Greg Fitzgerald [mailto:gregf@codeaurora.org] <br><b>Sent:</b> Tuesday, May 13, 2014 10:46 AM<br><b>To:</b> 'Kostya Serebryany'<br><b>Cc:</b> 'Commit Messages and Patches for LLVM'<br><b>Subject:</b> RE: [compiler-rt] r208624 - Add %run to new lit test<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>I have a local bot that runs a Go script that traverses the test tree and adds %run if it is missing. Should I add the script and add it to the build? Or need to port to Python?<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Thanks,<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Greg<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Kostya Serebryany [<a href="mailto:kcc@google.com">mailto:kcc@google.com</a>] <br><b>Sent:</b> Monday, May 12, 2014 9:15 PM<br><b>To:</b> Greg Fitzgerald<br><b>Cc:</b> Commit Messages and Patches for LLVM<br><b>Subject:</b> Re: [compiler-rt] r208624 - Add %run to new lit test<o:p></o:p></span></p><p class=MsoNormal><o:p> </o:p></p><div><p class=MsoNormal>Is it possible to make tests fail on regular Linux if they don't have %run? <o:p></o:p></p><div><p class=MsoNormal>Otherwise you will be fixing tests like this for eternity.<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>--kcc <o:p></o:p></p></div></div><div><p class=MsoNormal style='margin-bottom:12.0pt'><o:p> </o:p></p><div><p class=MsoNormal>On Tue, May 13, 2014 at 12:17 AM, Greg Fitzgerald <<a href="mailto:gregf@codeaurora.org" target="_blank">gregf@codeaurora.org</a>> wrote:<o:p></o:p></p><p class=MsoNormal>Author: garious<br>Date: Mon May 12 15:17:14 2014<br>New Revision: 208624<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=208624&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=208624&view=rev</a><br>Log:<br>Add %run to new lit test<br><br>Modified:<br> compiler-rt/trunk/test/asan/TestCases/Linux/coverage-module-unloaded.cc<br><br>Modified: compiler-rt/trunk/test/asan/TestCases/Linux/coverage-module-unloaded.cc<br>URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Linux/coverage-module-unloaded.cc?rev=208624&r1=208623&r2=208624&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Linux/coverage-module-unloaded.cc?rev=208624&r1=208623&r2=208624&view=diff</a><br>==============================================================================<br>--- compiler-rt/trunk/test/asan/TestCases/Linux/coverage-module-unloaded.cc (original)<br>+++ compiler-rt/trunk/test/asan/TestCases/Linux/coverage-module-unloaded.cc Mon May 12 15:17:14 2014<br>@@ -4,8 +4,8 @@<br> // RUN: %clangxx_asan -mllvm -asan-coverage=1 -DSHARED %s -shared -o %T/libcoverage_module_unloaded_test_2.so -fPIC<br> // RUN: %clangxx_asan -mllvm -asan-coverage=1 -DSO_DIR=\"%T\" %s -o %t<br> // RUN: export ASAN_OPTIONS=coverage=1:verbosity=1<br>-// RUN: %t 2>&1 | FileCheck %s<br>-// RUN: %t foo 2>&1 | FileCheck %s<br>+// RUN: %run %t 2>&1 | FileCheck %s<br>+// RUN: %run %t foo 2>&1 | FileCheck %s<br> //<br> // <a href="https://code.google.com/p/address-sanitizer/issues/detail?id=263" target="_blank">https://code.google.com/p/address-sanitizer/issues/detail?id=263</a><br> // XFAIL: android<br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><o:p></o:p></p></div><p class=MsoNormal><o:p> </o:p></p></div></div></body></html>