<div dir="ltr">Why this is not added to common lit config (test/<a href="http://lit.common.configured.in">lit.common.configured.in</a>) instead?</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, May 13, 2014 at 5:46 PM, Greg Fitzgerald <span dir="ltr"><<a href="mailto:gregf@codeaurora.org" target="_blank">gregf@codeaurora.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: garious<br>
Date: Tue May 13 19:46:01 2014<br>
New Revision: 208746<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=208746&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=208746&view=rev</a><br>
Log:<br>
Add target flags to ubsan tests<br>
<br>
Modified:<br>
    compiler-rt/trunk/test/ubsan/lit.common.cfg<br>
    compiler-rt/trunk/test/ubsan/<a href="http://lit.site.cfg.in" target="_blank">lit.site.cfg.in</a><br>
<br>
Modified: compiler-rt/trunk/test/ubsan/lit.common.cfg<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/lit.common.cfg?rev=208746&r1=208745&r2=208746&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/lit.common.cfg?rev=208746&r1=208745&r2=208746&view=diff</a><br>

==============================================================================<br>
--- compiler-rt/trunk/test/ubsan/lit.common.cfg (original)<br>
+++ compiler-rt/trunk/test/ubsan/lit.common.cfg Tue May 13 19:46:01 2014<br>
@@ -28,6 +28,8 @@ else:<br>
 def build_invocation(compile_flags):<br>
   return " " + " ".join([config.clang] + compile_flags) + " "<br>
<br>
+target_cflags = [get_required_attr(config, "target_cflags")]<br>
+clang_ubsan_cflags += target_cflags<br>
 clang_ubsan_cxxflags = config.cxx_mode_flags + clang_ubsan_cflags<br>
<br>
 # Define %clang and %clangxx substitutions to use in test RUN lines.<br>
<br>
Modified: compiler-rt/trunk/test/ubsan/<a href="http://lit.site.cfg.in" target="_blank">lit.site.cfg.in</a><br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/lit.site.cfg.in?rev=208746&r1=208745&r2=208746&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/lit.site.cfg.in?rev=208746&r1=208745&r2=208746&view=diff</a><br>

==============================================================================<br>
--- compiler-rt/trunk/test/ubsan/<a href="http://lit.site.cfg.in" target="_blank">lit.site.cfg.in</a> (original)<br>
+++ compiler-rt/trunk/test/ubsan/<a href="http://lit.site.cfg.in" target="_blank">lit.site.cfg.in</a> Tue May 13 19:46:01 2014<br>
@@ -3,6 +3,7 @@ lit_config.load_config(config, "@COMPILE<br>
<br>
 # Tool-specific config options.<br>
 config.ubsan_lit_test_mode = "@UBSAN_LIT_TEST_MODE@"<br>
+config.target_cflags = "@COMPILER_RT_TEST_COMPILER_CFLAGS@"<br>
<br>
 # Load tool-specific config that would do the real work.<br>
 lit_config.load_config(config, "@UBSAN_LIT_TESTS_DIR@/lit.common.cfg")<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><div>Alexey Samsonov, Mountain View, CA</div></div>
</div>