<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 13, 2014 at 10:45 AM, Greg Fitzgerald <span dir="ltr"><<a href="mailto:gregf@codeaurora.org" target="_blank">gregf@codeaurora.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><p class="MsoNormal">
<span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">I have a local bot that runs a Go script that traverses the test tree and adds %run if it is missing.  Should I add the script and add it to the build?  Or need to port to Python?</span></p>
</div></div></blockquote><div><br></div><div>What does this script do? If it (correctly) guesses the places where %run are not listed, you may incorporate it into lit checker: lib/sanitizer_common/scripts/check_lint.sh, which</div>
<div>is run automatically at every "make check-xsan" invocation.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple"><div><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">Thanks,<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">Greg<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class="MsoNormal"><b><span style="font-size:10pt;font-family:Tahoma,sans-serif">From:</span></b><span style="font-size:10pt;font-family:Tahoma,sans-serif"> Kostya Serebryany [mailto:<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>] <br>
<b>Sent:</b> Monday, May 12, 2014 9:15 PM<br><b>To:</b> Greg Fitzgerald<br><b>Cc:</b> Commit Messages and Patches for LLVM<br><b>Subject:</b> Re: [compiler-rt] r208624 - Add %run to new lit test<u></u><u></u></span></p><div>
<div class="h5"><p class="MsoNormal"><u></u> <u></u></p><div><p class="MsoNormal">Is it possible to make tests fail on regular Linux if they don't have %run? <u></u><u></u></p><div><p class="MsoNormal">Otherwise you will be fixing tests like this for eternity.<u></u><u></u></p>
</div><div><p class="MsoNormal"><u></u> <u></u></p></div><div><p class="MsoNormal">--kcc <u></u><u></u></p></div></div><div><p class="MsoNormal" style="margin-bottom:12pt"><u></u> <u></u></p><div><p class="MsoNormal">On Tue, May 13, 2014 at 12:17 AM, Greg Fitzgerald <<a href="mailto:gregf@codeaurora.org" target="_blank">gregf@codeaurora.org</a>> wrote:<u></u><u></u></p>
<p class="MsoNormal">Author: garious<br>Date: Mon May 12 15:17:14 2014<br>New Revision: 208624<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=208624&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=208624&view=rev</a><br>
Log:<br>Add %run to new lit test<br><br>Modified:<br>    compiler-rt/trunk/test/asan/TestCases/Linux/coverage-module-unloaded.cc<br><br>Modified: compiler-rt/trunk/test/asan/TestCases/Linux/coverage-module-unloaded.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Linux/coverage-module-unloaded.cc?rev=208624&r1=208623&r2=208624&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Linux/coverage-module-unloaded.cc?rev=208624&r1=208623&r2=208624&view=diff</a><br>
==============================================================================<br>--- compiler-rt/trunk/test/asan/TestCases/Linux/coverage-module-unloaded.cc (original)<br>+++ compiler-rt/trunk/test/asan/TestCases/Linux/coverage-module-unloaded.cc Mon May 12 15:17:14 2014<br>
@@ -4,8 +4,8 @@<br> // RUN: %clangxx_asan -mllvm -asan-coverage=1 -DSHARED %s -shared -o %T/libcoverage_module_unloaded_test_2.so -fPIC<br> // RUN: %clangxx_asan -mllvm -asan-coverage=1 -DSO_DIR=\"%T\" %s -o %t<br>
 // RUN: export ASAN_OPTIONS=coverage=1:verbosity=1<br>-// RUN: %t 2>&1         | FileCheck %s<br>-// RUN: %t foo 2>&1         | FileCheck %s<br>+// RUN: %run %t 2>&1         | FileCheck %s<br>+// RUN: %run %t foo 2>&1         | FileCheck %s<br>
 //<br> // <a href="https://code.google.com/p/address-sanitizer/issues/detail?id=263" target="_blank">https://code.google.com/p/address-sanitizer/issues/detail?id=263</a><br> // XFAIL: android<br><br><br>_______________________________________________<br>
llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><u></u><u></u></p>
</div><p class="MsoNormal"><u></u> <u></u></p></div></div></div></div></div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><div>Alexey Samsonov, Mountain View, CA</div></div>
</div></div>