<div dir="ltr">On Mon, May 12, 2014 at 12:14 PM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">our bot is sad:<div><a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/3364/steps/build%20stage1%20clang/logs/stdio" target="_blank">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/3364/steps/build%20stage1%20clang/logs/stdio</a><br>
</div><div><pre style="font-family:'Courier New',courier,monotype,monospace;color:rgb(0,0,0);font-size:medium"><span>FAILED: /usr/bin/cc -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -fPIC -Wall -W -Wno-unused-parameter -Wwrite-strings -Wno-missing-field-initializers -pedantic -Wno-long-long -Wno-comment -ffunction-sections -fdata-sections -Wall -O3 -DNDEBUG -Iprojects/compiler-rt/lib/builtins -I/home/dtoolsbot/build/sanitizer-x86_64-linux-bootstrap/build/llvm/projects/compiler-rt/lib/builtins -Iinclude -I/home/dtoolsbot/build/sanitizer-x86_64-linux-bootstrap/build/llvm/include -UNDEBUG -m32 -std=c99 -MMD -MT projects/compiler-rt/lib/builtins/CMakeFiles/clang_rt.i386.dir/clear_cache.c.o -MF "projects/compiler-rt/lib/builtins/CMakeFiles/clang_rt.i386.dir/clear_cache.c.o.d" -o projects/compiler-rt/lib/builtins/CMakeFiles/clang_rt.i386.dir/clear_cache.c.o -c /home/dtoolsbot/build/sanitizer-x86_64-linux-bootstrap/build/llvm/projects/compiler-rt/lib/builtins/clear_cache.c
/home/dtoolsbot/build/sanitizer-x86_64-linux-bootstrap/build/llvm/projects/compiler-rt/lib/builtins/clear_cache.c:35:20: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘void’
COMPILER_RT_EXPORT void
^
FAILED: /usr/bin/cc -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -fPIC -Wall -W -Wno-unused-parameter -Wwrite-strings -Wno-missing-field-initializers -pedantic -Wno-long-long -Wno-comment -ffunction-sections -fdata-sec</span><span>tions -Wall -O3 -DNDEBUG -Iprojects/compiler-rt/lib/builtins -I/home/dtoolsbot/build/sanitizer-x86_64-linux-bootstrap/build/llvm/projects/compiler-rt/lib/builtins -Iinclude -I/home/dtoolsbot/build/sanitizer-x86_64-linux-bootstrap/build/llvm/include -UNDEBUG -m64 -std=c99 -MMD -MT projects/compiler-rt/lib/builtins/CMakeFiles/clang_rt.x86_64.dir/clear_cache.c.o -MF "projects/compiler-rt/lib/builtins/CMakeFiles/clang_rt.x86_64.dir/clear_cache.c.o.d" -o projects/compiler-rt/lib/builtins/CMakeFiles/clang_rt.x86_64.dir/clear_cache.c.o -c /home/dtoolsbot/build/sanitizer-x86_64-linux-bootstrap/build/llvm/projects/compiler-rt/lib/builtins/clear_cache.c
</span><span>/home/dtoolsbot/build/sanitizer-x86_64-linux-bootstrap/build/llvm/projects/compiler-rt/lib/builtins/clear_cache.c:35:20: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘void’
COMPILER_RT_EXPORT void
^
ninja: build stopped: subcommand failed.</span></pre></div></div></blockquote><div>Yeah, I had accidentally left a file out of the commit. That should be available after SVN r208578. Sorry for the trouble.</div><div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div class="h5"><div class="gmail_extra"><br>
<div class="gmail_quote">On Mon, May 12, 2014 at 8:28 PM, Saleem Abdulrasool <span dir="ltr"><<a href="mailto:compnerd@compnerd.org" target="_blank">compnerd@compnerd.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: compnerd<br>
Date: Mon May 12 11:28:11 2014<br>
New Revision: 208591<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=208591&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=208591&view=rev</a><br>
Log:<br>
__clear_cache: decorate with COMPILER_RT_EXPORT<br>
<br>
Use COMPILER_RT_EXPORT rather than COMPILER_RT_ABI for this function. Adding an<br>
explicit PCS standard to the function causes a mismatch between the<br>
declarations. Furthermore, the function is implemented in C, and should take<br>
the CC based on the target triple.<br>
<br>
Modified:<br>
compiler-rt/trunk/lib/builtins/clear_cache.c<br>
<br>
Modified: compiler-rt/trunk/lib/builtins/clear_cache.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/builtins/clear_cache.c?rev=208591&r1=208590&r2=208591&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/builtins/clear_cache.c?rev=208591&r1=208590&r2=208591&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/builtins/clear_cache.c (original)<br>
+++ compiler-rt/trunk/lib/builtins/clear_cache.c Mon May 12 11:28:11 2014<br>
@@ -32,7 +32,7 @@<br>
* specified range.<br>
*/<br>
<br>
-COMPILER_RT_ABI void<br>
+COMPILER_RT_EXPORT void<br>
__clear_cache(void* start, void* end)<br>
{<br>
#if __i386__ || __x86_64__<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org
</div></div>