<div dir="ltr">+Sandra Loosemore</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, May 9, 2014 at 2:18 AM, Alexey Samsonov <span dir="ltr"><<a href="mailto:samsonov@google.com" target="_blank">samsonov@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">This is incorrect. PTRACE_GETSIGINFO is defined as:<div><div><br></div><div>  /* Get siginfo for process.  */</div>
<div>  PTRACE_GETSIGINFO = 0x4202,</div><div>#define PT_GETSIGINFO PTRACE_GETSIGINFO</div></div>
<div><br></div><div>So, we should also use PT_GETSIGINFO macro for that. I've submitted a fix in r208363.</div><div><br></div></div><div class="gmail_extra"><div><div class="h5"><br><br><div class="gmail_quote">On Tue, May 6, 2014 at 12:36 AM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: kcc<br>
Date: Tue May  6 02:36:51 2014<br>
New Revision: 208066<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=208066&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=208066&view=rev</a><br>
Log:<br>
[sanitizer] fix build with glibc 2.4, patch by Sandra Loosemore<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_platform_limits_posix.cc<br>
<br>
Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_platform_limits_posix.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_platform_limits_posix.cc?rev=208066&r1=208065&r2=208066&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_platform_limits_posix.cc?rev=208066&r1=208065&r2=208066&view=diff</a><br>


==============================================================================<br>
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_platform_limits_posix.cc (original)<br>
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_platform_limits_posix.cc Tue May  6 02:36:51 2014<br>
@@ -288,15 +288,20 @@ namespace __sanitizer {<br>
   int ptrace_setfpregs = PTRACE_SETFPREGS;<br>
   int ptrace_getfpxregs = PTRACE_GETFPXREGS;<br>
   int ptrace_setfpxregs = PTRACE_SETFPXREGS;<br>
+#if defined(PTRACE_GETSIGINFO) && defined(PTRACE_SETSIGINFO)<br>
   int ptrace_getsiginfo = PTRACE_GETSIGINFO;<br>
   int ptrace_setsiginfo = PTRACE_SETSIGINFO;<br>
+#else<br>
+  int ptrace_getsiginfo = -1;<br>
+  int ptrace_setsiginfo = -1;<br>
+#endif  // PTRACE_GETSIGINFO/PTRACE_SETSIGINFO<br>
 #if defined(PTRACE_GETREGSET) && defined(PTRACE_SETREGSET)<br>
   int ptrace_getregset = PTRACE_GETREGSET;<br>
   int ptrace_setregset = PTRACE_SETREGSET;<br>
 #else<br>
   int ptrace_getregset = -1;<br>
   int ptrace_setregset = -1;<br>
-#endif<br>
+#endif  // PTRACE_GETREGSET/PTRACE_SETREGSET<br>
 #endif<br>
<br>
   unsigned path_max = PATH_MAX;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div dir="ltr"><div>Alexey Samsonov, Mountain View, CA</div></div>
</font></span></div>
</blockquote></div><br></div>