<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Thanks Tom!<div><br></div><div>This is r<span style="font-family: Menlo; font-size: 11px;">208371.</span><div apple-content-edited="true">
<div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br></div><div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">-<span style="text-align: -webkit-auto;">Quentin</span></div>
</div>
<br><div style=""><div>On May 8, 2014, at 4:13 PM, Tom Stellard <<a href="mailto:tom@stellard.net">tom@stellard.net</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">LGTM.<br><br>-Tom<br><br>On Thu, May 08, 2014 at 04:04:13PM -0700, Quentin Colombet wrote:<br><blockquote type="cite">Hi,<br><br>The proposed patch relaxes the behavior of TargetInstrInfo::commuteInstruction when TargetInstrInfo::findCommutedOpIndices returns false.<br><br>Currently TargetInstrInfo triggers a fatal error in such situation whereas based on the comment in the API[1] it should just return nullptr. Indeed the only precondition that should be ensured is that the instruction must be commutable.<br><br>Spotted via code inspection.<br><br>Is it okay to commit?<br><br>[1]<br> /// commuteInstruction - If a target has any instructions that are<br> /// commutable but require converting to different instructions or making<br> /// non-trivial changes to commute them, this method can overloaded to do<br> /// that. The default implementation simply swaps the commutable operands.<br> /// If NewMI is false, MI is modified in place and returned; otherwise, a<br> /// new machine instruction is created and returned. Do not call this<br> /// method for a non-commutable instruction, but there may be some cases<br> /// where this method fails and returns null.<br><br>Thanks,<br>-Quentin<br></blockquote><br><blockquote type="cite">_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote><br></blockquote></div><br></div></body></html>