<div dir="ltr">LGTM</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, May 5, 2014 at 7:57 PM, Timur Iskhodzhanov <span dir="ltr"><<a href="mailto:timurrrr@google.com" target="_blank">timurrrr@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi kcc,<br>
<br>
<a href="http://reviews.llvm.org/D3610" target="_blank">http://reviews.llvm.org/D3610</a><br>
<br>
Files:<br>
  lib/asan/asan_rtl.cc<br>
  lib/sanitizer_common/sanitizer_win.cc<br>
<br>
Index: lib/asan/asan_rtl.cc<br>
===================================================================<br>
--- lib/asan/asan_rtl.cc<br>
+++ lib/asan/asan_rtl.cc<br>
@@ -178,7 +178,8 @@<br>
<br>
   ParseFlag(str, &f->disable_core, "disable_core",<br>
       "Disable core dumping. By default, disable_core=1 on 64-bit to avoid "<br>
-      "dumping a 16T+ core file.");<br>
+      "dumping a 16T+ core file. "<br>
+      "Ignored on architectures that don't dump core by default.");<br>
<br>
   ParseFlag(str, &f->allow_reexec, "allow_reexec",<br>
       "Allow the tool to re-exec the program. This may interfere badly with "<br>
Index: lib/sanitizer_common/sanitizer_win.cc<br>
===================================================================<br>
--- lib/sanitizer_common/sanitizer_win.cc<br>
+++ lib/sanitizer_common/sanitizer_win.cc<br>
@@ -185,7 +185,7 @@<br>
 }<br>
<br>
 void DisableCoreDumper() {<br>
-  UNIMPLEMENTED();<br>
+  // Do nothing.<br>
 }<br>
<br>
 void ReExec() {<br>
</blockquote></div><br></div>