<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div></div><div><br></div><div>Thanks,</div><div>Michael</div><div><br></div><div><div>On Apr 30, 2014, at 10:22 PM, Michael Zolotukhin <<a href="mailto:mzolotukhin@apple.com">mzolotukhin@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Thanks, Juergen!<div><br></div><div>Before check-in I’m going to run some additional testing and wait for an update from Quentin (and maybe comments from others).</div><div><br></div><div>Michael</div><div><br><div><div>On Apr 30, 2014, at 9:13 PM, Juergen Ributzka <<a href="mailto:juergen@apple.com">juergen@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Thanks for fixing this Michael. LGTM<div>-Juergen<br><div><div><div>On Apr 30, 2014, at 7:49 AM, Michael Zolotukhin <<a href="mailto:mzolotukhin@apple.com">mzolotukhin@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br>On Apr 30, 2014, at 5:17 PM, Hal Finkel <<a href="mailto:hfinkel@anl.gov">hfinkel@anl.gov</a>> wrote:<br><br><blockquote type="cite">----- Original Message -----<br><blockquote type="cite">From: "Michael Zolotukhin" <<a href="mailto:mzolotukhin@apple.com">mzolotukhin@apple.com</a>><br>To: "llvm commits" <<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>><br>Sent: Wednesday, April 30, 2014 8:11:16 AM<br>Subject: Tweak ConstantHoisting on X86<br><br><br><br>Hi,<br><br>ConstantHoisting currently could lead to inefficient code on X86 (the<br>test is attached). Recently Juergen has solved a similar issue on<br>ARM64, so these changes do the same on X86. The change is to<br>disallow hoisting of constants from shift instructions.<br><br>While the original issue that I’m fixing is on X86, the same problem<br>could happen on other platforms. So, I prepared two versions of the<br>patch: the first one touches only X86, and the other changes<br>ConstantHoisting itself. Personally, I’d prefer the X86-only<br>version, because I don’t know much about other targets affected. Any<br>thoughts on this?<br></blockquote><br>Yes, please use the x86-only version. I would not want exactly this behavior for PowerPC, for example.<br></blockquote>Sure.<br><br><blockquote type="cite">-Hal<br><br><blockquote type="cite"><br>There is one more important detail. With this change test<br>CodeGen/X86/remat-invalid-liveness.ll stops to check what it’s<br>supposed to check. Right now I just silenced it, but we probably<br>want to rewrite and make it less fragile. Quentin, could you please<br>take a look and help me with that?<br></blockquote></blockquote>I’ve found a simple way to fix the test - as the current change prevents constants from hoisting, I did it in the test manually. Now it checks what it checked before. Also to make sure it’s still relevant I checked that it fails if r206060 is reverted.<br><br>Here is an updated patch:<br><span><ConstantHoisting-x86-v2.patch></span><br><br>Is it ok to commit?<br><br>Thanks,<br>Michael<br><br><blockquote type="cite"><blockquote type="cite"><br>Thanks,<br>Michael<br><br><br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br><br></blockquote><br>--<span class="Apple-converted-space"> </span><br>Hal Finkel<br>Assistant Computational Scientist<br>Leadership Computing Facility<br>Argonne National Laboratory<br></blockquote><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></div></div></div></blockquote></div><br></div></div>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br></body></html>