<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Apr 28, 2014 at 4:13 PM, Eli Bendersky <span dir="ltr"><<a href="mailto:eliben@google.com" target="_blank">eliben@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div class="">On Mon, Apr 28, 2014 at 4:06 PM, Richard Smith <span dir="ltr"><<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>On Mon, Apr 28, 2014 at 3:32 PM, Eli Bendersky <span dir="ltr"><<a href="mailto:eliben@google.com" target="_blank">eliben@google.com</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>On Mon, Apr 28, 2014 at 3:28 PM, Eric Christopher <span dir="ltr"><<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Uh, that'd be the wrong grouping I imagine?<span><font color="#888888"><br></font></span></blockquote><div><br></div>
</div><div>Good catch, will fix. The original was wrong too, so the gcc warning was spot on here ;-)</div></div></div></div></blockquote><div><br></div></div><div>Actually, the code is correct either way. Clang has special case handling to avoid the false positive for this pattern. =)</div>
</div></div></div></blockquote><div><br></div></div><div>Interesting. Can you elaborate (or point to this special case in Clang's sources)? </div></div></div></div></blockquote><div><br></div><div>Look at SemaChecking.cpp, around line 6156. In particular, we don't warn on:</div>
<div><br></div><div>assert(A || B && "string literal");</div><div><br></div><div>... because (a) this is a common pattern, and (b) the precedence of || and && doesn't matter here because && "string literal" is a no-op.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><span style="color:rgb(80,0,80)"> </span></div>
<div><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div>
<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span><font color="#888888"><div>
Eli</div></font></span><div><div><div>
<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span><font color="#888888">
-eric<br>
</font></span><div><div><br>
On Mon, Apr 28, 2014 at 3:19 PM, Eli Bendersky <<a href="mailto:eliben@google.com" target="_blank">eliben@google.com</a>> wrote:<br>
> Author: eliben<br>
> Date: Mon Apr 28 17:19:12 2014<br>
> New Revision: 207452<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=207452&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=207452&view=rev</a><br>
> Log:<br>
> Add (...) around && clause to appeace gcc 4.8's warning<br>
><br>
> Modified:<br>
> llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br>
><br>
> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=207452&r1=207451&r2=207452&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=207452&r1=207451&r2=207452&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)<br>
> +++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Mon Apr 28 17:19:12 2014<br>
> @@ -591,9 +591,9 @@ std::unique_ptr<DIE> DwarfDebug::constru<br>
> DIScope DS(Scope->getScopeNode());<br>
><br>
> assert(Scope->getInlinedAt() ||<br>
> - !DS.isSubprogram() && "Only handle inlined subprograms here, use "<br>
> - "constructSubprogramScopeDIE for non-inlined "<br>
> - "subprograms");<br>
> + (!DS.isSubprogram() && "Only handle inlined subprograms here, use "<br>
> + "constructSubprogramScopeDIE for non-inlined "<br>
> + "subprograms"));<br>
><br>
> SmallVector<std::unique_ptr<DIE>, 8> Children;<br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div></div></div><br></div></div>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div></div></div><br></div></div>
</blockquote></div></div></div><br></div></div>
</blockquote></div><br></div></div>