<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Apr 28, 2014 at 3:55 PM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class=""><br><div class="gmail_quote">On Fri, Apr 25, 2014 at 1:39 PM, Andrew Trick <span dir="ltr"><<a href="mailto:atrick@apple.com" target="_blank">atrick@apple.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="overflow:hidden">Adam,<br>
<br>
This fix looks great to me! Please go ahead and commit.</div></blockquote></div><br></div>Andy, how does this look good? ;]</div><div class="gmail_extra"><br></div><div class="gmail_extra"><div class="gmail_extra">--- /dev/null</div>

<div class="gmail_extra">+++ b/test/Transforms/LoopStrengthReduce/ARM64/req-regs.c</div><div class="gmail_extra">@@ -0,0 +1,36 @@</div><div class="gmail_extra">+// RUN: clang %s -O3 -target arm64-apple-ios -o - -S -mllvm -debug-only=loop-reduce 2>&1| FileCheck %s</div>

<div class="gmail_extra">+// REQUIRES: asserts</div><div class="gmail_extra">+</div><div class="gmail_extra">+// LSR used to fail here due to a bug in the ReqRegs test.  To complicate</div><div class="gmail_extra">+// things, this could only be reproduced with clang because the uses would</div>

<div class="gmail_extra">+// come out in different order when invoked through llc.</div><div class="gmail_extra">+</div><div class="gmail_extra">+// CHECK: The chosen solution requires</div><div class="gmail_extra">+// CHECK-NOT: No Satisfactory Solution</div>

<div class="gmail_extra"><br></div><div class="gmail_extra">This test runs clang, from the users PATH, with -O3, in an LLVM test. This doesn't work *at all*.</div><div class="gmail_extra"><br></div><div class="gmail_extra">

That really doesn't work. Mind reverting until you have a reduced test case? This is blocking us, so I'd like to get it fixed ASAP.</div></div></div></blockquote><div><br></div><div>FYI, caught Andy on IRC and he said it would be fine to just revert for now. Sorry for the trouble. Happy to follow up here as needed. </div>
</div><br></div></div>