On Sunday, April 27, 2014, Aaron Ballman <<a href="mailto:aaron@aaronballman.com">aaron@aaronballman.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Sun, Apr 27, 2014 at 1:28 AM, Saleem Abdulrasool<br>
<<a href="javascript:;" onclick="_e(event, 'cvml', 'compnerd@compnerd.org')">compnerd@compnerd.org</a>> wrote:<br>
> Author: compnerd<br>
> Date: Sun Apr 27 00:28:10 2014<br>
> New Revision: 207350<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=207350&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=207350&view=rev</a><br>
> Log:<br>
> ARM: MSVC does not support = default<br>
><br>
> Explicitly "implement" the destructor as MSVC does not support defaulted methods<br>
> yet.<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMWinCOFFObjectWriter.cpp<br>
><br>
> Modified: llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMWinCOFFObjectWriter.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMWinCOFFObjectWriter.cpp?rev=207350&r1=207349&r2=207350&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMWinCOFFObjectWriter.cpp?rev=207350&r1=207349&r2=207350&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMWinCOFFObjectWriter.cpp (original)<br>
> +++ llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMWinCOFFObjectWriter.cpp Sun Apr 27 00:28:10 2014<br>
> @@ -23,7 +23,7 @@ public:<br>
>      : MCWinCOFFObjectTargetWriter(COFF::IMAGE_FILE_MACHINE_ARMNT) {<br>
>      assert(!Is64Bit && "AArch64 support not yet implemented");<br>
>    }<br>
> -  virtual ~ARMWinCOFFObjectWriter() = default;<br>
> +  virtual ~ARMWinCOFFObjectWriter() { }<br>
<br>
Would it make more sense to add LLVM_DEFAULTED_FUNCTION to Compiler.h<br>
to complement LLVM_DELETED_FUNCTION?</blockquote><div><br></div><div>Maybe I'm missing something<span></span>, how would the macro work for operator= or copy constructors?  Unlike the delete function which can be made private, the only way that I can think of getting equivalent behaviour is to implement them.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
~Aaron<br>
</blockquote><br><br>-- <br>Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org<br>