<div dir="rtl"><div dir="ltr">Yes, the LGTM by nico Rieck was in that thread, it was easy to miss since the thread was mostly about the SEH, I opened Phabricator for the other related patches.</div><div dir="ltr"><br></div>
<div dir="ltr">The patch was in r206565 and the test in r206566. I modified the test myself.</div><div dir="ltr"><br></div><div dir="ltr">The r206565 patch consists of four trivial line codes. Is it OK to rewrite it from scratch and resubmit it?</div>
<div dir="ltr"><br></div><div dir="ltr">Yaron</div><div dir="ltr"><br></div></div><div class="gmail_extra"><div dir="ltr"><br><br><div class="gmail_quote">2014-04-18 12:34 GMT+03:00 Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I found the review thread for this and commented there, however there is a greater problem. Ray Donnelly did not contribute this patch to LLVM in any way. You cannot apply patches unless the *author* of the code contributes it. Please see the developer's policy which has a section directly addressing this: <a href="http://llvm.org/docs/DeveloperPolicy.html#attribution-of-changes" target="_blank">http://llvm.org/docs/DeveloperPolicy.html#attribution-of-changes</a><div>
<br></div><div>I'm going to revert this and the related patches immediately just to get the tree into a clean state. This isn't any kind of punishment, it is just incredibly important that we only ever have patches in the tree that were contributed openly and according to our developer policy.</div>
</blockquote></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Apr 18, 2014 at 2:27 AM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Yaron, this patch never got reviewed on the list. There was no LGTM, and certainly none of the maintainers of MC looked at it. Please revert and wait for proper review before committing.</div>
<div><div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Fri, Apr 18, 2014 at 1:03 AM, Yaron Keren <span dir="ltr"><<a href="mailto:yaron.keren@gmail.com" target="_blank">yaron.keren@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: yrnkrn<br>
Date: Fri Apr 18 03:03:38 2014<br>
New Revision: 206565<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=206565&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=206565&view=rev</a><br>
Log:<br>
Patch by Ray Donnelly.<br>
<br>
Emit WIN64 SEH registers by name instead of just number.<br>
<br>
<br>
Modified:<br>
llvm/trunk/lib/MC/MCAsmStreamer.cpp<br>
<br>
Modified: llvm/trunk/lib/MC/MCAsmStreamer.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCAsmStreamer.cpp?rev=206565&r1=206564&r2=206565&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCAsmStreamer.cpp?rev=206565&r1=206564&r2=206565&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/MC/MCAsmStreamer.cpp (original)<br>
+++ llvm/trunk/lib/MC/MCAsmStreamer.cpp Fri Apr 18 03:03:38 2014<br>
@@ -1257,14 +1257,17 @@ void MCAsmStreamer::EmitWin64EHHandlerDa<br>
void MCAsmStreamer::EmitWin64EHPushReg(unsigned Register) {<br>
MCStreamer::EmitWin64EHPushReg(Register);<br>
<br>
- OS << "\t.seh_pushreg " << Register;<br>
+ OS << "\t.seh_pushreg ";<br>
+ EmitRegisterName(Register);<br>
EmitEOL();<br>
}<br>
<br>
void MCAsmStreamer::EmitWin64EHSetFrame(unsigned Register, unsigned Offset) {<br>
MCStreamer::EmitWin64EHSetFrame(Register, Offset);<br>
<br>
- OS << "\t.seh_setframe " << Register << ", " << Offset;<br>
+ OS << "\t.seh_setframe ";<br>
+ EmitRegisterName(Register);<br>
+ OS << ", " << Offset;<br>
EmitEOL();<br>
}<br>
<br>
@@ -1278,14 +1281,18 @@ void MCAsmStreamer::EmitWin64EHAllocStac<br>
void MCAsmStreamer::EmitWin64EHSaveReg(unsigned Register, unsigned Offset) {<br>
MCStreamer::EmitWin64EHSaveReg(Register, Offset);<br>
<br>
- OS << "\t.seh_savereg " << Register << ", " << Offset;<br>
+ OS << "\t.seh_savereg ";<br>
+ EmitRegisterName(Register);<br>
+ OS << ", " << Offset;<br>
EmitEOL();<br>
}<br>
<br>
void MCAsmStreamer::EmitWin64EHSaveXMM(unsigned Register, unsigned Offset) {<br>
MCStreamer::EmitWin64EHSaveXMM(Register, Offset);<br>
<br>
- OS << "\t.seh_savexmm " << Register << ", " << Offset;<br>
+ OS << "\t.seh_savexmm ";<br>
+ EmitRegisterName(Register);<br>
+ OS << ", " << Offset;<br>
EmitEOL();<br>
}<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></div></div>