<div dir="ltr">Yaron, this patch never got reviewed on the list. There was no LGTM, and certainly none of the maintainers of MC looked at it. Please revert and wait for proper review before committing.</div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Fri, Apr 18, 2014 at 1:03 AM, Yaron Keren <span dir="ltr"><<a href="mailto:yaron.keren@gmail.com" target="_blank">yaron.keren@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: yrnkrn<br>
Date: Fri Apr 18 03:03:38 2014<br>
New Revision: 206565<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=206565&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=206565&view=rev</a><br>
Log:<br>
Patch by Ray Donnelly.<br>
<br>
Emit WIN64 SEH registers by name instead of just number.<br>
<br>
<br>
Modified:<br>
    llvm/trunk/lib/MC/MCAsmStreamer.cpp<br>
<br>
Modified: llvm/trunk/lib/MC/MCAsmStreamer.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCAsmStreamer.cpp?rev=206565&r1=206564&r2=206565&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCAsmStreamer.cpp?rev=206565&r1=206564&r2=206565&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/MC/MCAsmStreamer.cpp (original)<br>
+++ llvm/trunk/lib/MC/MCAsmStreamer.cpp Fri Apr 18 03:03:38 2014<br>
@@ -1257,14 +1257,17 @@ void MCAsmStreamer::EmitWin64EHHandlerDa<br>
 void MCAsmStreamer::EmitWin64EHPushReg(unsigned Register) {<br>
   MCStreamer::EmitWin64EHPushReg(Register);<br>
<br>
-  OS << "\t.seh_pushreg " << Register;<br>
+  OS << "\t.seh_pushreg ";<br>
+  EmitRegisterName(Register);<br>
   EmitEOL();<br>
 }<br>
<br>
 void MCAsmStreamer::EmitWin64EHSetFrame(unsigned Register, unsigned Offset) {<br>
   MCStreamer::EmitWin64EHSetFrame(Register, Offset);<br>
<br>
-  OS << "\t.seh_setframe " << Register << ", " << Offset;<br>
+  OS << "\t.seh_setframe ";<br>
+  EmitRegisterName(Register);<br>
+  OS << ", " << Offset;<br>
   EmitEOL();<br>
 }<br>
<br>
@@ -1278,14 +1281,18 @@ void MCAsmStreamer::EmitWin64EHAllocStac<br>
 void MCAsmStreamer::EmitWin64EHSaveReg(unsigned Register, unsigned Offset) {<br>
   MCStreamer::EmitWin64EHSaveReg(Register, Offset);<br>
<br>
-  OS << "\t.seh_savereg " << Register << ", " << Offset;<br>
+  OS << "\t.seh_savereg ";<br>
+  EmitRegisterName(Register);<br>
+  OS << ", " << Offset;<br>
   EmitEOL();<br>
 }<br>
<br>
 void MCAsmStreamer::EmitWin64EHSaveXMM(unsigned Register, unsigned Offset) {<br>
   MCStreamer::EmitWin64EHSaveXMM(Register, Offset);<br>
<br>
-  OS << "\t.seh_savexmm " << Register << ", " << Offset;<br>
+  OS << "\t.seh_savexmm ";<br>
+  EmitRegisterName(Register);<br>
+  OS << ", " << Offset;<br>
   EmitEOL();<br>
 }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>