<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Thanks! Committed as r206433.<div><br></div><div>Adam<br><div><br><div><div>On Apr 16, 2014, at 5:45 PM, Quentin Colombet <<a href="mailto:qcolombet@apple.com">qcolombet@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=us-ascii"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi Adam,<div><br></div><div>LGTM.</div><div><br></div><div>Thanks,<br><div apple-content-edited="true">
<div style="font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">-Quentin</div>
</div>
<br><div style=""><div>On Apr 16, 2014, at 3:27 PM, Adam Nemet <<a href="mailto:anemet@apple.com">anemet@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">The commit of r205855:<br><br>Author: Arnold Schwaighofer <<a href="mailto:aschwaighofer@apple.com">aschwaighofer@apple.com</a>><br>Date: Wed Apr 9 14:20:47 2014 +0000<br><br> SLPVectorizer: Only vectorize intrinsics whose operands are widened equally<br><br> The vectorizer only knows how to vectorize intrinics by widening all operands by<br> the same factor.<br><br> Patch by Tyler Nowicki!<br><br>exposed a backend bug causing a regression (Cannot select ctpop).<br><br>The commit msg is a bit confusing because the patch actually changes the<br>behavior for the loop-vectorizer as well. As things got refactored into a<br>helper ctpop got snuck in to the trivially-vectorizable helper which is now<br>used by both vectorizers. In other words, we started seeing vector-ctpops in<br>the backend.<br><br>This change makes ctpop LegalizeAction::Expand for the types not supported by<br>the byte-only CNT instruction. We may be able to custom-lower these later to<br>a single CNT but this is to fix the compiler crash first.<br><br>Fixes <<a href="rdar://problem/16578951">rdar://problem/16578951</a>><br><br>Adam<br><br><span><ARM64-Fix-Cannot-select-for-vector-ctpop.patch></span>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br></blockquote></div><br></div></div></blockquote></div><br></div></div></body></html>