<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi James,<div><br></div><div>If you look closer, this is a different place than where you added the FIXME.</div><div>Indeed, this is the MC layer not the ARM64Subtarget thing.</div><div>Therefore, we still have this one to fix and yes, it will trigger tons of file check failures :).</div><div><br></div><div>I’ll get into it.</div><div><br></div><div>Thanks,<br><div apple-content-edited="true">
<div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">-Quentin</div>
</div>
<br><div><div>On Apr 15, 2014, at 12:56 AM, James Molloy <<a href="mailto:james@jamesmolloy.co.uk">james@jamesmolloy.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Hi Quentin,<div><br></div><div>Thanks for doing this. I added the FIXME instead of doing it myself as I was concerned there'd be a ton of filecheck failures from tests that don't specify "darwin" and expect cyclone specific output. Looks like I was mistaken :)</div>
<div><br></div><div>Cheers,</div><div><br></div><div>James</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 15 April 2014 01:28, Quentin Colombet <span dir="ltr"><<a href="mailto:qcolombet@apple.com" target="_blank">qcolombet@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: qcolombet<br>
Date: Mon Apr 14 19:28:39 2014<br>
New Revision: 206228<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=206228&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=206228&view=rev</a><br>
Log:<br>
[ARM64][MC] Set the default CPU string to generic.<br>
<br>
Modified:<br>
llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp?rev=206228&r1=206227&r2=206228&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp?rev=206228&r1=206227&r2=206228&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp (original)<br>
+++ llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp Mon Apr 14 19:28:39 2014<br>
@@ -44,10 +44,8 @@ static MCSubtargetInfo *createARM64MCSub<br>
StringRef FS) {<br>
MCSubtargetInfo *X = new MCSubtargetInfo();<br>
<br>
- // FIXME: Make this darwin-only.<br>
if (CPU.empty())<br>
- // We default to Cyclone for now, on Darwin.<br>
- CPU = "cyclone";<br>
+ CPU = "generic";<br>
<br>
InitARM64MCSubtargetInfo(X, TT, CPU, FS);<br>
return X;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</blockquote></div><br></div></body></html>