<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Oops. I missed a spot when nuking the auto detection stuff, it looks like. Fixing!<div><br></div><div>r206220</div><div><br></div><div>-Jim<br><div><br></div><div><br><div><div>On Apr 14, 2014, at 3:00 PM, Quentin Colombet <<a href="mailto:qcolombet@apple.com">qcolombet@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Sorry, I thought I was doing the same thing as X86 here.<div>I’ve been misled by this sequence:</div><div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">MCSubtargetInfo *X86_MC::createX86MCSubtargetInfo(StringRef TT, StringRef CPU,</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> StringRef FS) {</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">[...]</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> std::string CPUName = CPU;</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> if (CPUName.empty()) {</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">#if defined(i386) || defined(__i386__) || defined(__x86__) || defined(_M_IX86)\</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> || defined(__x86_64__) || defined(_M_AMD64) || defined (_M_X64)</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> CPUName = sys::getHostCPUName();</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">#else</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> CPUName = "generic";</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">#endif</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> }</div></div><div><br></div><div>Let me rework my copy then!</div><div><br></div><div><div apple-content-edited="true">
<div style="font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">-Quentin</div>
</div>
<br><div><div>On Apr 14, 2014, at 2:42 PM, Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Uh, what?<br><br>How about taking the same code from the ARM or X86 backends? Or something else?<br><br>-eric<br><br>On Mon, Apr 14, 2014 at 2:25 PM, Quentin Colombet <<a href="mailto:qcolombet@apple.com">qcolombet@apple.com</a>> wrote:<br><blockquote type="cite">Author: qcolombet<br>Date: Mon Apr 14 16:25:53 2014<br>New Revision: 206211<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=206211&view=rev">http://llvm.org/viewvc/llvm-project?rev=206211&view=rev</a><br>Log:<br>[ARM64][MC] Set the default CPU to cyclone when initilizating the MC layer.<br>This matches that ARM64Subtarget does for now.<br><br>This is related to <<a href="rdar://problem/16573920">rdar://problem/16573920</a>><br><br>Modified:<br> llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp<br><br>Modified: llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp<br>URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp?rev=206211&r1=206210&r2=206211&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp?rev=206211&r1=206210&r2=206211&view=diff</a><br>==============================================================================<br>--- llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp (original)<br>+++ llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp Mon Apr 14 16:25:53 2014<br>@@ -43,6 +43,12 @@ static MCInstrInfo *createARM64MCInstrIn<br> static MCSubtargetInfo *createARM64MCSubtargetInfo(StringRef TT, StringRef CPU,<br> StringRef FS) {<br> MCSubtargetInfo *X = new MCSubtargetInfo();<br>+<br>+ // FIXME: Make this darwin-only.<br>+ if (CPU.empty())<br>+ // We default to Cyclone for now, on Darwin.<br>+ CPU = "cyclone";<br>+<br> InitARM64MCSubtargetInfo(X, TT, CPU, FS);<br> return X;<br> }<br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br></blockquote></blockquote></div><br></div></div>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br></div></div></body></html>