<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">On Apr 14, 2014, at 2:50 PM, Nick Lewycky <<a href="mailto:nlewycky@google.com">nlewycky@google.com</a>> wrote:<br><div><blockquote type="cite"><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>There's also some interesting differences because PSVs are passed by pointer while MachinePointerInfo is passed by value. It means more changes to more APIs.</div><div><br></div><div>The next problem is MipsCallEntry which *derives* from PseudoSourceValue, but never declared it in the Value enum list. There is no way that possibly works, and I'm not yet sure what to do about it.</div><div><br></div><div>Chris, breaking PSV off of Value is a reasonable first step. Can we start there? Or do you *really* want a larger patch that removes PSV all in one go?<br></div></div></div></div></div></blockquote><br></div><div>I'm an incremental development kind of guy, please do it in reasonable steps.</div><div><br></div><div>-Chris</div><br></body></html>