<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Well, in fact, I am not sure what is the best approach here.<div><br></div><div>ARM and X86 already seem to duplicate this logic somehow, see below.</div><div><br></div><div>So if we are about to duplicate something I’d prefer to keep it minimal like in the current patch.</div><div><br></div><div>What do you think?</div><div><br></div><div>** X86 **</div><div><br></div><div>— X86Subtarget.cpp:</div><div><div>void X86Subtarget::resetSubtargetFeatures(StringRef CPU, StringRef FS) {</div><div> std::string CPUName = CPU;</div><div> if (CPUName.empty())</div><div> CPUName = "generic";</div></div><div><br></div><div>— X86MCTargetDesc.cpp:</div><div><div>MCSubtargetInfo *X86_MC::createX86MCSubtargetInfo(StringRef TT, StringRef CPU,</div><div> StringRef FS) {</div><div>[…]</div><div> std::string CPUName = CPU;</div><div> if (CPUName.empty()) {</div><div>#if defined(i386) || defined(__i386__) || defined(__x86__) || defined(_M_IX86)\</div><div> || defined(__x86_64__) || defined(_M_AMD64) || defined (_M_X64)</div><div> CPUName = sys::getHostCPUName();</div><div>#else</div><div> CPUName = "generic";</div><div>#endif</div><div> }</div></div><div><br></div><div><br></div><div>** ARM **</div><div><br></div><div><div>— ARMSubtarget.cpp:</div><div><div><div>void ARMSubtarget::resetSubtargetFeatures(StringRef CPU, StringRef FS) {</div><div> if (CPUString.empty()) {</div><div> if (isTargetIOS() && TargetTriple.getArchName().endswith("v7s"))</div><div> // Default to the Swift CPU when targeting armv7s/thumbv7s.</div><div> CPUString = "swift";</div><div> else</div><div> CPUString = "generic";</div><div> }</div></div></div><div><br></div><div>— ARMMCTargetDesc.cpp:</div><div>std::string ARM_MC::ParseARMTriple(StringRef TT, StringRef CPU) {</div><div>[...]</div><div></div></div><div><div> bool NoCPU = CPU == "generic" || CPU.empty();</div><div> std::string ARMArchFeature;</div><div> if (Idx) {</div><div> unsigned SubVer = TT[Idx];</div><div> if (SubVer == '8') {</div><div> if (NoCPU)</div><div> // v8a: FeatureDB, FeatureFPARMv8, FeatureNEON, FeatureDSPThumb2,</div><div> // FeatureMP, FeatureHWDiv, FeatureHWDivARM, FeatureTrustZone,</div><div> // FeatureT2XtPk, FeatureCrypto, FeatureCRC</div><div> ARMArchFeature = "+v8,+db,+fp-armv8,+neon,+t2dsp,+mp,+hwdiv,+hwdiv-arm,"</div><div> "+trustzone,+t2xtpk,+crypto,+crc";</div><div> else</div><div> // Use CPU to figure out the exact features</div><div> ARMArchFeature = "+v8”;</div><div>[…]</div><div><br></div><div apple-content-edited="true">
<div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">-Quentin</div>
</div>
<br><div><div>On Apr 14, 2014, at 3:02 PM, Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Thanks!<br><br>I'd probably see the ARM one as closer... it doesn't cope well if<br>there's no cpu given it doesn't look like :)<br><br>-eric<br><br>On Mon, Apr 14, 2014 at 3:00 PM, Quentin Colombet <<a href="mailto:qcolombet@apple.com">qcolombet@apple.com</a>> wrote:<br><blockquote type="cite">Sorry, I thought I was doing the same thing as X86 here.<br>I’ve been misled by this sequence:<br>MCSubtargetInfo *X86_MC::createX86MCSubtargetInfo(StringRef TT, StringRef<br>CPU,<br> StringRef FS) {<br>[...]<br> std::string CPUName = CPU;<br> if (CPUName.empty()) {<br>#if defined(i386) || defined(__i386__) || defined(__x86__) ||<br>defined(_M_IX86)\<br> || defined(__x86_64__) || defined(_M_AMD64) || defined (_M_X64)<br> CPUName = sys::getHostCPUName();<br>#else<br> CPUName = "generic";<br>#endif<br> }<br><br>Let me rework my copy then!<br><br>-Quentin<br><br>On Apr 14, 2014, at 2:42 PM, Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:<br><br>Uh, what?<br><br>How about taking the same code from the ARM or X86 backends? Or something<br>else?<br><br>-eric<br><br>On Mon, Apr 14, 2014 at 2:25 PM, Quentin Colombet <<a href="mailto:qcolombet@apple.com">qcolombet@apple.com</a>><br>wrote:<br><br>Author: qcolombet<br>Date: Mon Apr 14 16:25:53 2014<br>New Revision: 206211<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=206211&view=rev">http://llvm.org/viewvc/llvm-project?rev=206211&view=rev</a><br>Log:<br>[ARM64][MC] Set the default CPU to cyclone when initilizating the MC layer.<br>This matches that ARM64Subtarget does for now.<br><br>This is related to <<a href="rdar://problem/16573920">rdar://problem/16573920</a>><br><br>Modified:<br> llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp<br><br>Modified: llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp<br>URL:<br><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp?rev=206211&r1=206210&r2=206211&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp?rev=206211&r1=206210&r2=206211&view=diff</a><br>==============================================================================<br>--- llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp<br>(original)<br>+++ llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp Mon Apr<br>14 16:25:53 2014<br>@@ -43,6 +43,12 @@ static MCInstrInfo *createARM64MCInstrIn<br>static MCSubtargetInfo *createARM64MCSubtargetInfo(StringRef TT, StringRef<br>CPU,<br> StringRef FS) {<br> MCSubtargetInfo *X = new MCSubtargetInfo();<br>+<br>+ // FIXME: Make this darwin-only.<br>+ if (CPU.empty())<br>+ // We default to Cyclone for now, on Darwin.<br>+ CPU = "cyclone";<br>+<br> InitARM64MCSubtargetInfo(X, TT, CPU, FS);<br> return X;<br>}<br><br><br>_______________________________________________<br>llvm-commits mailing list<br>llvm-commits@cs.uiuc.edu<br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br><br><br></blockquote></blockquote></div><br></div></body></html>