<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Apr 10, 2014 at 9:32 AM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">On Wed, Apr 9, 2014 at 7:48 PM, Saleem Abdulrasool<br>
<<a href="mailto:compnerd@compnerd.org">compnerd@compnerd.org</a>> wrote:<br>
> Author: compnerd<br>
> Date: Wed Apr  9 21:48:10 2014<br>
> New Revision: 205949<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=205949&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=205949&view=rev</a><br>
> Log:<br>
> ARM64: add an explicit cast to silence a silly warning<br>
<br>
</div>If the warning is bad, can we just disable it for the project instead<br>
of working around it?</blockquote><div><br></div><div>Im not convinced that the warning is bad in all cases.  It could identify places where you return a value that is invalid in the associated enumeration.  As such, I think seeing how often it gets triggered and whether it is always invalid might be a good idea.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
><br>
> GCC 4.8 complains with:<br>
>   warning: enumeral and non-enumeral type in conditional expression<br>
><br>
> Although this is silly and harmless in this case, add an explicit cast to<br>
> silence the warning.<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/Target/ARM64/ARM64TargetTransformInfo.cpp<br>
><br>
> Modified: llvm/trunk/lib/Target/ARM64/ARM64TargetTransformInfo.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM64/ARM64TargetTransformInfo.cpp?rev=205949&r1=205948&r2=205949&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM64/ARM64TargetTransformInfo.cpp?rev=205949&r1=205948&r2=205949&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/lib/Target/ARM64/ARM64TargetTransformInfo.cpp (original)<br>
> +++ llvm/trunk/lib/Target/ARM64/ARM64TargetTransformInfo.cpp Wed Apr  9 21:48:10 2014<br>
> @@ -227,7 +227,8 @@ unsigned ARM64TTI::getIntImmCost(unsigne<br>
>    if (Idx == ImmIdx) {<br>
>      unsigned NumConstants = (BitSize + 63) / 64;<br>
>      unsigned Cost = ARM64TTI::getIntImmCost(Imm, Ty);<br>
> -    return (Cost <= NumConstants * TCC_Basic) ? TCC_Free : Cost;<br>
> +    return (Cost <= NumConstants * TCC_Basic)<br>
> +      ? static_cast<unsigned>(TCC_Free) : Cost;<br>
>    }<br>
>    return ARM64TTI::getIntImmCost(Imm, Ty);<br>
>  }<br>
> @@ -252,7 +253,8 @@ unsigned ARM64TTI::getIntImmCost(Intrins<br>
>      if (Idx == 1) {<br>
>        unsigned NumConstants = (BitSize + 63) / 64;<br>
>        unsigned Cost = ARM64TTI::getIntImmCost(Imm, Ty);<br>
> -      return (Cost <= NumConstants * TCC_Basic) ? TCC_Free : Cost;<br>
> +      return (Cost <= NumConstants * TCC_Basic)<br>
> +        ? static_cast<unsigned>(TCC_Free) : Cost;<br>
>      }<br>
>      break;<br>
>    case Intrinsic::experimental_stackmap:<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org
</div></div>