<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Chatted with David and Iain about these on IRC a bit. They are OK for inclusion in 3.4.1.<div><br></div><div>-Jim</div><div><br><div><div>On Apr 9, 2014, at 3:30 PM, David Fang <<a href="mailto:fang@csl.cornell.edu">fang@csl.cornell.edu</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Hi Tom,<br><span class="Apple-tab-span" style="white-space: pre;"> </span>Thanks for committing most of these to 3.4.1!<br><br>Just two remain:<br>LLVM:<br>r196970 [mine] -- .weak_definition vs. .weak_def_can_be_hidden (legacy asm)<br><br>Clang:<br>r196981 [mine] -- suppress -Q for legacy system assembler (driver)<br><br>I have been using both of these in my own fink packages of llvm/clang on OS X 10.4 through 10.7 since the initial 3.4 release.<br><br>Are these OK for 3.4.1? Jim?<br>When you announce a branch freeze or release candidate, I'll do another merge to my own legacy support branches and test.<br><br>David<br><br><blockquote type="cite">On 28 March 2014 22:19, David Fang <<a href="mailto:fang@csl.cornell.edu">fang@csl.cornell.edu</a>> wrote:<br><blockquote type="cite">Hi Tom,<br> Thanks for doing this. I would like to nominate the following<br>patches to be backported to release_34 (3.4.1).<br><br>LLVM:<br>r196168, r196970 -- .weak_definition vs. .weak_def_can_be_hidden<br> (r196168 is Rafael's, 970 is mine)<br>r196987, r197572, r197574 -- [ABI] f64,i64 alignment on ppc-darwin<br> all Rafael's, 196987 is a cosmetic change that made it easier<br> to apply the others.<br>r198744 [Iain Sandoe] -- FDE cross-section relocs for EH<br><br><a href="https://github.com/fangism/llvm/tree/powerpc-darwin8-rel-3.4">https://github.com/fangism/llvm/tree/powerpc-darwin8-rel-3.4</a><br><br>- - - - - - - - - - - - - - - - - -<br>Clang:<br>r197577 [Rafael] -- f64 alignment ppc-darwin struct layout<br>r196981 [me] -- suppress -Q for legacy system assembler<br><br>https://github.com/fangism/clang/tree/powerpc-darwin8-rel-3.4<br><br></blockquote><br>For what it is worth, I think this is fine. The changes are either low<br>risk for being ppc-darwin local or are simple cleanups.<br><br>Cheers,<br>Rafael<br><br></blockquote><br>--<span class="Apple-converted-space"> </span><br>David Fang<br><a href="http://www.csl.cornell.edu/~fang/">http://www.csl.cornell.edu/~fang/</a></div></blockquote></div><br></div></body></html>