<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Hi Hal,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">
Ah, I see. Do you mean the test is using -loop-vectorize rather than -loop-unroll? Then I'm OK with the original CHECK sequence.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">
<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Thanks,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">-Jiangning</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">
<br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2014-04-09 13:50 GMT+08:00 Hal Finkel <span dir="ltr"><<a href="mailto:hfinkel@anl.gov" target="_blank">hfinkel@anl.gov</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="">----- Original Message -----<br>
> From: "Jiangning Liu" <<a href="mailto:liujiangning1@gmail.com">liujiangning1@gmail.com</a>><br>
> To: "Zhaoshi" <<a href="mailto:zhaoshiz@codeaurora.org">zhaoshiz@codeaurora.org</a>><br>
> Cc: "<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a> for LLVM" <<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>><br>
> Sent: Wednesday, April 9, 2014 12:30:25 AM<br>
> Subject: Re: [Patch] [AArch64] Implement getMaximumUnrollFactor()<br>
><br>
><br>
><br>
><br>
> Hi Zhaoshi,<br>
><br>
><br>
><br>
> +;CHECK-LABEL: array_add<br>
> +;CHECK: load <4 x i32><br>
> +;CHECK: load <4 x i32><br>
> +;CHECK: load <4 x i32><br>
> +;CHECK: load <4 x i32><br>
> +;CHECK: add nsw <4 x i32><br>
> +;CHECK: add nsw <4 x i32><br>
> +;CHECK: store <4 x i32><br>
> +;CHECK: store <4 x i32><br>
> +;CHECK: ret<br>
><br>
><br>
> Since we don't really have out-of-order CHECK,<br>
<br>
</div>Do you mean CHECK-DAG?<br>
<div class=""><br>
> this CHECK ordering<br>
> could fail after loop unrolling in theory, right?<br>
<br>
</div>FWIW, I think that the form above is better because it makes it clear that you're looking for the vectorizer's interleaved unrolling (and not the concatenation unrolling from the generic unroller).<br>
<br>
 -Hal<br>
<div class="HOEnZb"><div class="h5"><br>
> Maybe simply<br>
> checking there are only two stores like below is enough?<br>
><br>
><br>
><br>
> ;CHECK: store <4 x i32><br>
> ;CHECK: store <4 x i32><br>
> ;CHECK-NOT: store<br>
><br>
><br>
> Thanks,<br>
> -Jiangning<br>
><br>
><br>
><br>
><br>
><br>
> 2014-04-08 9:26 GMT+08:00 < <a href="mailto:zhaoshiz@codeaurora.org">zhaoshiz@codeaurora.org</a> > :<br>
><br>
><br>
> Hello,<br>
><br>
> This patch allows vectorized loops to be unrolled by a factor of 2 on<br>
> AArch64. Please help review<br>
><br>
> Thanks,<br>
> Zhaoshi<br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
><br>
><br>
><br>
><br>
> --<br>
><br>
> Thanks,<br>
> -Jiangning<br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
<br>
--<br>
</div></div><span class="HOEnZb"><font color="#888888">Hal Finkel<br>
Assistant Computational Scientist<br>
Leadership Computing Facility<br>
Argonne National Laboratory<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><font face="courier new, monospace">Thanks,</font><div><font face="courier new, monospace">-Jiangning</font></div></div>
</div>