<div dir="ltr">It was typo. Sorry.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Apr 4, 2014 at 3:45 PM, Shankar Easwaran <span dir="ltr"><<a href="mailto:shankare@codeaurora.org" target="_blank">shankare@codeaurora.org</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Comment says --dynsym and implementation reflects --defsym.<br>
<br>
Incorrect comment ?<div class="HOEnZb"><div class="h5"><br>
<br>
On 4/4/2014 5:36 PM, Rui Ueyama wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: ruiu<br>
Date: Fri Apr  4 17:36:30 2014<br>
New Revision: 205654<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=205654&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=205654&view=rev</a><br>
Log:<br>
[ELF] Diagnose malformed --dynsym option.<br>
<br>
Modified:<br>
     lld/trunk/lib/Driver/<u></u>GnuLdDriver.cpp<br>
     lld/trunk/unittests/<u></u>DriverTests/GnuLdDriverTest.<u></u>cpp<br>
<br>
Modified: lld/trunk/lib/Driver/<u></u>GnuLdDriver.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/GnuLdDriver.cpp?rev=205654&r1=205653&r2=205654&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lld/trunk/lib/Driver/<u></u>GnuLdDriver.cpp?rev=205654&r1=<u></u>205653&r2=205654&view=diff</a><br>


==============================<u></u>==============================<u></u>==================<br>
--- lld/trunk/lib/Driver/<u></u>GnuLdDriver.cpp (original)<br>
+++ lld/trunk/lib/Driver/<u></u>GnuLdDriver.cpp Fri Apr  4 17:36:30 2014<br>
@@ -134,7 +134,7 @@ static error_code getFileMagic(ELFLinkin<br>
  // aliases yet.<br>
  static bool parseDefsymOption(StringRef opt, StringRef &sym, uint64_t &addr) {<br>
    size_t equalPos = opt.find('=');<br>
-  if (equalPos == StringRef::npos)<br>
+  if (equalPos == 0 || equalPos == StringRef::npos)<br>
      return false;<br>
    sym = opt.substr(0, equalPos);<br>
    if (opt.substr(equalPos + 1).getAsInteger(0, addr))<br>
<br>
Modified: lld/trunk/unittests/<u></u>DriverTests/GnuLdDriverTest.<u></u>cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/unittests/DriverTests/GnuLdDriverTest.cpp?rev=205654&r1=205653&r2=205654&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lld/trunk/unittests/<u></u>DriverTests/GnuLdDriverTest.<u></u>cpp?rev=205654&r1=205653&r2=<u></u>205654&view=diff</a><br>


==============================<u></u>==============================<u></u>==================<br>
--- lld/trunk/unittests/<u></u>DriverTests/GnuLdDriverTest.<u></u>cpp (original)<br>
+++ lld/trunk/unittests/<u></u>DriverTests/GnuLdDriverTest.<u></u>cpp Fri Apr  4 17:36:30 2014<br>
@@ -71,3 +71,13 @@ TEST_F(GnuLdParserTest, DefsymFail) {<br>
    EXPECT_FALSE(<br>
        parse("ld", "--start-group", "--end-group", "--defsym=sym=abc", nullptr));<br>
  }<br>
+<br>
+TEST_F(GnuLdParserTest, DefsymMisssingSymbol) {<br>
+  EXPECT_FALSE(<br>
+      parse("ld", "--start-group", "--end-group", "--defsym==0", nullptr));<br>
+}<br>
+<br>
+TEST_F(GnuLdParserTest, DefsymMisssingValue) {<br>
+  EXPECT_FALSE(<br>
+      parse("ld", "--start-group", "--end-group", "--defsym=sym=", nullptr));<br>
+}<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
<br>
<br>
</blockquote>
<br>
<br></div></div><span class="HOEnZb"><font color="#888888">
-- <br>
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation<br>
<br>
</font></span></blockquote></div><br></div>