<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Committed Chris’s patch as r<span style="font-family: Menlo; font-size: 11px;">205478.</span><div><div>On Mar 27, 2014, at 7:36 PM, Daniel Dunbar <<a href="mailto:daniel@zuster.org">daniel@zuster.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">I'm fine with killing FileUpdate.<span></span><br><br>On Thursday, March 27, 2014, Reid Kleckner <<a href="mailto:rnk@google.com">rnk@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Patch LGTM.<div><br></div><div>Should we nuke FileUpdate? It looks like it was added in 2009 / r77954, and it hasn't been used since then. All the other commits are updates for lib/Support changes. CMake already has a solution to the problem it's trying to solve, and we're trying to standardize on the CMake build and kill the autoconf build.</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Mar 27, 2014 at 10:34 AM, Chris Bieneman <span dir="ltr"><<a href="javascript:_e(%7B%7D,'cvml','cbieneman@apple.com');" target="_blank">cbieneman@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">There is an LLVM_INSTALL_TOOLCHAIN_ONLY option which adds only the toolchain tools to the install list, but you still end up building the non-toolchain tools and utils. I could rework the patch to instead be LLVM_BUILD_TOOLCHIAN_ONLY if that is a preferable route.<span><font color="#888888"><div>
<br></div><div>-Chris</div></font></span><div><br><div><div>On Mar 26, 2014, at 10:08 PM, Reid Kleckner <<a href="javascript:_e(%7B%7D,'cvml','rnk@google.com');" target="_blank">rnk@google.com</a>> wrote:</div>
<br><blockquote type="cite">
<div dir="ltr">Don't we already have functionality for this? LLVM_BUILD_TOOLCHAIN_ONLY or something like that? Can we extend that with various levels instead?</div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Wed, Mar 26, 2014 at 8:07 PM, Chris Bieneman <span dir="ltr"><<a href="javascript:_e(%7B%7D,'cvml','cbieneman@apple.com');" target="_blank">cbieneman@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
For shipping products that include llvm libraries and tools we want the ability to not build some of the LLVM utilities (FileCheck, FileUpdate, count, not, llvm-lit, and yaml-bench).<br>
<br>
This patch accomplishes this by adding a new CMake option LLVM_INCLUDE_UTILS which excludes those subdirectories. This patch also adds an error if you set LLVM_INCLUDE_UTILS to OFF while setting LLVM_INCLUDE_TESTS to ON, because including tests necessitates including the utils.<br>
<br>
-Chris<br>
<br>
Files:<br>
CMakelists.txt<br>
<br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="javascript:_e(%7B%7D,'cvml','llvm-commits@cs.uiuc.edu');" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></div></div>
</blockquote></div><br></div>
</blockquote>
_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br></body></html>