<div dir="rtl"><div dir="ltr">I renamed <span style="font-family:arial,sans-serif;font-size:12.727272033691406px">isTargetWindows() to </span><font face="arial, sans-serif">isTargetKnownWindowsMSVC() </font>in r<span style="font-size:12.727272033691406px;font-family:arial,sans-serif">205338.</span></div>

<div dir="ltr"><span style="font-size:12.727272033691406px;font-family:arial,sans-serif"><br></span></div></div><div class="gmail_extra"><br><br><div class="gmail_quote"><div dir="ltr">2014-03-30 7:35 GMT+03:00 NAKAMURA Takumi <span dir="ltr"><<a href="mailto:geek4civic@gmail.com" target="_blank">geek4civic@gmail.com</a>></span>:</div>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: chapuni<br>
Date: Sat Mar 29 23:35:00 2014<br>
New Revision: 205124<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=205124&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=205124&view=rev</a><br>
Log:<br>
X86Subtarget.h: isTargetWindows() should tell whether he is targeting msvc.<br>
<br>
FYI, !isWindowsGNUEnvironment() is insufficient. It missed cygwin.<br>
<br>
FIXME: The name "isTargetWindows" should be fixed.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/X86/X86Subtarget.h<br>
<br>
Modified: llvm/trunk/lib/Target/X86/X86Subtarget.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86Subtarget.h?rev=205124&r1=205123&r2=205124&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86Subtarget.h?rev=205124&r1=205123&r2=205124&view=diff</a><br>


==============================================================================<br>
--- llvm/trunk/lib/Target/X86/X86Subtarget.h (original)<br>
+++ llvm/trunk/lib/Target/X86/X86Subtarget.h Sat Mar 29 23:35:00 2014<br>
@@ -344,8 +344,7 @@ public:<br>
   bool isTargetNaCl32() const { return isTargetNaCl() && !is64Bit(); }<br>
   bool isTargetNaCl64() const { return isTargetNaCl() && is64Bit(); }<br>
   bool isTargetWindows() const {<br>
-    return TargetTriple.isOSWindows() &&<br>
-           !TargetTriple.isWindowsGNUEnvironment();<br>
+    return TargetTriple.isKnownWindowsMSVCEnvironment();<br>
   }<br>
   bool isTargetMingw() const { return TargetTriple.isWindowsGNUEnvironment(); }<br>
   bool isTargetCygwin() const {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>