<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">LGTM.<br>
<br>
On 4/1/2014 10:27 PM, Rui Ueyama wrote:<br>
</div>
<blockquote
cite="mid:differential-rev-PHID-DREV-2szrx3rba3qdh555gri4-req@llvm-reviews.chandlerc.com"
type="cite">
<pre wrap="">Hi Bigcheese, shankarke, kledzik,
LinkingContext and InputGraph are unnecessarily entangled. Most linker
input file data, e.g. the vector containing input files, the next index
of the input file, etc. are managed by InputGraph, but only the current
input file is for no obvious reason managed by LinkingContext.
This patch is to move code from LinkingContext to InputGraph to fix it.
It's now clear who's reponsible for managing input file state, which is
InputGraph, and LinkingContext is now free from that responsibility.
It improves the readability as we now have fewer dependencies between
classes. No functionality change.
<a class="moz-txt-link-freetext" href="http://llvm-reviews.chandlerc.com/D3259">http://llvm-reviews.chandlerc.com/D3259</a>
Files:
include/lld/Core/InputGraph.h
include/lld/Core/LinkingContext.h
lib/Core/InputGraph.cpp
lib/Core/LinkingContext.cpp
lib/Core/Resolver.cpp
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation</pre>
</body>
</html>