<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 3/31/2014 1:31 PM, Rui Ueyama wrote:<br>
</div>
<blockquote
cite="mid:CAJENXgshjy5UWsQ1WTgr+LMyW0m4bxRP-sHrvQ=ahYK8PhnA0g@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">On Mon, Mar 31, 2014 at 11:21 AM,
Shankar Easwaran <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:shankare@codeaurora.org" target="_blank">shankare@codeaurora.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div class="">
<div>On 3/31/2014 1:02 PM, Rui Ueyama wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote"><br>
<div>I did not simply push back this patch but
also pointed out some issues that were in
your patch with a suggestion.</div>
<div><br>
</div>
<div>My suggestion was to merge it with COMDAT
group section if they share the same
semantics. If COMDAT groups and
.gnu.linkonce sections need to be
distinguished only to detect collisions of
different types, i'd be great if we can
compartment that detail in a small piece of
code in Resolver, rather than spreading <span
style="font-family:arial,sans-serif;font-size:13px">typeGroupComdat||typeGnuLinkOnce
at every if's. Can't you use name prefix
".gnu.linkonce" to detect one section is a
.gnu.linkonce section? If not, can't you
add a new attribute for it?</span></div>
<div><br>
</div>
</div>
</div>
</div>
</blockquote>
</div>
I dont want to make a comparison on section names in the
resolver.</div>
</blockquote>
<div><br>
</div>
<div>Why? It might not feel very clean, but thinking that
.gnu.linkonce is a kind of reserved name, and this is for
compatibility with old tools that still produces
.gnu.linkonce instead of COMDAT group sections, that may
be good enough.</div>
</div>
</div>
</div>
</blockquote>
As you have already mentioned its not very clean, other reasons that
I have are as below :-<br>
<br>
a) Increase in lld IR's file size (when a file has a lot of
.gnu.linkonce sections)<br>
b) attribute scale across formats<br>
c) formats that dont have sections can use this functionality, if
there is a need.<br>
d) simple reason, we have only attributes to identify things in lld
with the atom model.<br>
e) much faster than comparing every group atom if its part of a
.gnu.linkonce section<br>
f) less cleaner without attributes<br>
<br>
Thanks<br>
<br>
Shankar Easwaran<br>
<pre class="moz-signature" cols="72">--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation</pre>
</body>
</html>