<div dir="ltr">The patch looks good, and I'll commit if klutzy acknowledges on llvm-commits that they want it upstream.  I just want to comply with the attribution policy:<div><a href="http://llvm.org/docs/DeveloperPolicy.html#attribution-of-changes">http://llvm.org/docs/DeveloperPolicy.html#attribution-of-changes</a><br>
</div><div><br></div><div>I'm not sure how wise it is to touch pvArbitrary, but hey, we do it for 32-bit.  *shrug*</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Mar 31, 2014 at 5:04 PM, Alex Crichton <span dir="ltr"><<a href="mailto:alex@crichton.co" target="_blank">alex@crichton.co</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">As part of the ongoing effort to upstream the patches that we're using<br>
with the Rust language, this is a patch which adds support for<br>
segmented stacks on 64-bit windows using MinGW. The original author<br>
was @klutzy on GitHub [1], and I've just added some tests to it.<br>
<br>
The implementation is the same as the 32-bit windows implementation by<br>
assuming that the stack limit is in the TIB's arbitrary data slot [2].<br>
The location of the TIB is slightly different, being pointed to by %gs<br>
instead of %fs [3].<br>
<br>
If anything else is required, please just let me know!<br>
<br>
[1] - <a href="https://github.com/rust-lang/llvm/commit/12d885" target="_blank">https://github.com/rust-lang/llvm/commit/12d885</a><br>
[2] - <a href="http://en.wikipedia.org/wiki/Win32_Thread_Information_Block" target="_blank">http://en.wikipedia.org/wiki/Win32_Thread_Information_Block</a><br>
[3] - <a href="http://en.wikipedia.org/wiki/X86-64" target="_blank">http://en.wikipedia.org/wiki/X86-64</a><br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>