<div dir="ltr">Thanks Dave!</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Mar 27, 2014 at 4:42 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dblaikie<br>
Date: Thu Mar 27 18:42:21 2014<br>
New Revision: 204983<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=204983&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=204983&view=rev</a><br>
Log:<br>
PBQP: Minor cleanups to r204857<br>
<br>
* Use assignment instead of swap (since the original value is being<br>
  destroyed anyway)<br>
<br>
* Rename "updateAdjEdgeId" to "setAdjEdgeId"<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/CodeGen/PBQP/Graph.h<br>
<br>
Modified: llvm/trunk/include/llvm/CodeGen/PBQP/Graph.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/PBQP/Graph.h?rev=204983&r1=204982&r2=204983&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/PBQP/Graph.h?rev=204983&r1=204982&r2=204983&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/include/llvm/CodeGen/PBQP/Graph.h (original)<br>
+++ llvm/trunk/include/llvm/CodeGen/PBQP/Graph.h Thu Mar 27 18:42:21 2014<br>
@@ -70,12 +70,12 @@ namespace PBQP {<br>
       void removeAdjEdgeId(Graph &G, NodeId ThisNId, AdjEdgeIdx Idx) {<br>
         // Swap-and-pop for fast removal.<br>
         //   1) Update the adj index of the edge currently at back().<br>
-        //   2) Swap Edge at Idx with back().<br>
+        //   2) Move last Edge down to Idx.<br>
         //   3) pop_back()<br>
-        // If Idx == size() - 1 then the updateAdjEdgeIdx and swap are<br>
+        // If Idx == size() - 1 then the setAdjEdgeIdx and swap are<br>
         // redundant, but both operations are cheap.<br>
-        G.getEdge(AdjEdgeIds.back()).updateAdjEdgeIdx(ThisNId, Idx);<br>
-        std::swap(AdjEdgeIds[Idx], AdjEdgeIds.back());<br>
+        G.getEdge(AdjEdgeIds.back()).setAdjEdgeIdx(ThisNId, Idx);<br>
+        AdjEdgeIds[Idx] = AdjEdgeIds.back();<br>
         AdjEdgeIds.pop_back();<br>
       }<br>
<br>
@@ -125,7 +125,7 @@ namespace PBQP {<br>
         connectToN(G, ThisEdgeId, 1);<br>
       }<br>
<br>
-      void updateAdjEdgeIdx(NodeId NId, typename NodeEntry::AdjEdgeIdx NewIdx) {<br>
+      void setAdjEdgeIdx(NodeId NId, typename NodeEntry::AdjEdgeIdx NewIdx) {<br>
         if (NId == NIds[0])<br>
           ThisEdgeAdjIdxs[0] = NewIdx;<br>
         else {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>