<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Mar 21, 2014 at 3:16 PM, Adrian Prantl <span dir="ltr"><<a href="mailto:aprantl@apple.com" target="_blank">aprantl@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: adrian<br>
Date: Fri Mar 21 17:16:32 2014<br>
New Revision: 204528<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=204528&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=204528&view=rev</a><br>
Log:<br>
Dwarf Debug: Remove some cargo-cult type uniquing. Scopes do not have<br>
an ID, so this is a noop.<br>
Thanks Manman for catching this!<br>
<br>
Modified:<br>
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br>
<br>
Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=204528&r1=204527&r2=204528&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=204528&r1=204527&r2=204528&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Fri Mar 21 17:16:32 2014<br>
@@ -604,7 +604,7 @@ DIE *DwarfDebug::constructScopeDIE(Dwarf<br>
     return NULL;<br>
<br>
   // Unique scope where applicable.<br>
-  DIScope DS(resolve(DIScope(Scope->getScopeNode()).getRef()));<br>
+  DIScope DS(Scope->getScopeNode());<br></blockquote><div><br></div><div>Right now, DICompositeType has an ID and it is also one kind of DIScope, so the statement "scopes do not have an ID" sounds incorrect :]</div>
<div><br></div><div>DISubprogram does not have an ID and we should remove the following noop:</div><div><br></div><div><div>/// getOrCreateSubprogramDIE - Create new DIE using SP.</div><div>DIE *DwarfUnit::getOrCreateSubprogramDIE(DISubprogram SP) {</div>
<div>  ...</div><div>  // Unique declarations based on the ODR, where applicable.</div><div>  SP = DISubprogram(DD->resolve(SP.getRef()));</div><div><br></div><br></div><div>Thanks,</div><div>Manman</div><div><br></div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
   SmallVector<DIE *, 8> Children;<br>
   DIE *ObjectPointer = NULL;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>