<div dir="ltr">Looks more like a bot misconfiguration... (or a bug in build files, or some such)</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Mar 17, 2014 at 11:37 AM, Alexey Samsonov <span dir="ltr"><<a href="mailto:samsonov@google.com" target="_blank">samsonov@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">FYI this broke MSan tests:<div><a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/7988/steps/run%20msan%20unit%20tests/logs/stdio" target="_blank">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/7988/steps/run%20msan%20unit%20tests/logs/stdio</a><br>

</div></div><div class="gmail_extra"><div><div class="h5"><br><br><div class="gmail_quote">On Mon, Mar 17, 2014 at 9:00 AM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: kcc<br>
Date: Mon Mar 17 00:00:35 2014<br>
New Revision: 204029<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=204029&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=204029&view=rev</a><br>
Log:<br>
[sanitizer] make real_pthread_attr_getstack extern "C"<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc<br>
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux_libcdep.cc<br>
<br>
Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc?rev=204029&r1=204028&r2=204029&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc?rev=204029&r1=204028&r2=204029&view=diff</a><br>


==============================================================================<br>
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc (original)<br>
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc Mon Mar 17 00:00:35 2014<br>
@@ -2880,9 +2880,11 @@ INTERCEPTOR(int, pthread_attr_getstack,<br>
 // in sanitizer_common, but we don't want to include the interception headers<br>
 // there. So, just define this function here.<br>
 namespace __sanitizer {<br>
+extern "C" {<br>
 int real_pthread_attr_getstack(void *attr, void **addr, SIZE_T *size) {<br>
   return REAL(pthread_attr_getstack)(attr, addr, size);<br>
 }<br>
+}  // extern "C"<br>
 }  // namespace __sanitizer<br>
<br>
 #define INIT_PTHREAD_ATTR_GET                             \<br>
<br>
Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux_libcdep.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux_libcdep.cc?rev=204029&r1=204028&r2=204029&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux_libcdep.cc?rev=204029&r1=204028&r2=204029&view=diff</a><br>


==============================================================================<br>
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux_libcdep.cc (original)<br>
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux_libcdep.cc Mon Mar 17 00:00:35 2014<br>
@@ -50,8 +50,10 @@<br>
 namespace __sanitizer {<br>
<br>
 // This function is defined elsewhere if we intercepted pthread_attr_getstack.<br>
+extern "C" {<br>
 SANITIZER_WEAK_ATTRIBUTE int<br>
 real_pthread_attr_getstack(void *attr, void **addr, size_t *size);<br>
+}  // extern "C"<br>
<br>
 static int my_pthread_attr_getstack(void *attr, void **addr, size_t *size) {<br>
   if (real_pthread_attr_getstack)<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div>Alexey Samsonov, MSK</div>
</font></span></div>
</blockquote></div><br></div>