<div dir="ltr">Should be fixed by r203786.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Mar 12, 2014 at 6:33 PM, Timur Iskhodzhanov <span dir="ltr"><<a href="mailto:timurrrr@google.com" target="_blank">timurrrr@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">FTR, this has implicitly enabled /W4 in our Windows build.<br>
W4 is a super-pedantic warning level, so we should really use /W3 (or<br>
-W3) on Windows.<br>
<br>
2014-03-06 16:25 GMT+04:00 Alexey Samsonov <<a href="mailto:samsonov@google.com">samsonov@google.com</a>>:<br>
<div class="HOEnZb"><div class="h5">> Author: samsonov<br>
> Date: Thu Mar  6 06:25:02 2014<br>
> New Revision: 203113<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=203113&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=203113&view=rev</a><br>
> Log:<br>
> [CMake] Build compiler-rt libraries with -Wall<br>
><br>
> Modified:<br>
>     compiler-rt/trunk/CMakeLists.txt<br>
>     compiler-rt/trunk/cmake/config-ix.cmake<br>
><br>
> Modified: compiler-rt/trunk/CMakeLists.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/CMakeLists.txt?rev=203113&r1=203112&r2=203113&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/CMakeLists.txt?rev=203113&r1=203112&r2=203113&view=diff</a><br>

> ==============================================================================<br>
> --- compiler-rt/trunk/CMakeLists.txt (original)<br>
> +++ compiler-rt/trunk/CMakeLists.txt Thu Mar  6 06:25:02 2014<br>
> @@ -235,6 +235,7 @@ pythonize_bool(COMPILER_RT_DEBUG)<br>
>  #================================<br>
>  include(config-ix)<br>
><br>
> +add_definitions_if(COMPILER_RT_HAS_WALL_FLAG -Wall)<br>
>  if(COMPILER_RT_ENABLE_WERROR)<br>
>    add_definitions_if(COMPILER_RT_HAS_WERROR_FLAG -Werror)<br>
>    add_definitions_if(COMPILER_RT_HAS_WX_FLAG /WX)<br>
><br>
> Modified: compiler-rt/trunk/cmake/config-ix.cmake<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/cmake/config-ix.cmake?rev=203113&r1=203112&r2=203113&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/cmake/config-ix.cmake?rev=203113&r1=203112&r2=203113&view=diff</a><br>

> ==============================================================================<br>
> --- compiler-rt/trunk/cmake/config-ix.cmake (original)<br>
> +++ compiler-rt/trunk/cmake/config-ix.cmake Thu Mar  6 06:25:02 2014<br>
> @@ -26,6 +26,7 @@ check_cxx_compiler_flag(-g COMPILER_RT_H<br>
>  check_cxx_compiler_flag(/Zi COMPILER_RT_HAS_Zi_FLAG)<br>
><br>
>  # Warnings.<br>
> +check_cxx_compiler_flag(-Wall COMPILER_RT_HAS_WALL_FLAG)<br>
>  check_cxx_compiler_flag(-Werror COMPILER_RT_HAS_WERROR_FLAG)<br>
>  check_cxx_compiler_flag("-Werror -Wframe-larger-than=512" COMPILER_RT_HAS_WFRAME_LARGER_THAN_FLAG)<br>
>  check_cxx_compiler_flag("-Werror -Wglobal-constructors"   COMPILER_RT_HAS_WGLOBAL_CONSTRUCTORS_FLAG)<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Alexey Samsonov, MSK</div>
</div>