<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
BTW, the second link there is a different change, only related
insofar as it also breaks threaded MCJIT in some cases.<br>
<br>
<div class="moz-cite-prefix">On 03/13/2014 01:49 PM, Ivan
Puzyrevskiy wrote:<br>
</div>
<blockquote
cite="mid:7B496421-5779-485C-AE3F-DC780A18FA0E@yandex-team.ru"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
Jim pointed out to me that patch was approved some time ago but it
didn’t make its way to the trunk. See:
<div>
<div>
<div><br>
</div>
<div><a moz-do-not-send="true"
href="http://comments.gmane.org/gmane.comp.compilers.llvm.cvs/161966">http://comments.gmane.org/gmane.comp.compilers.llvm.cvs/161966</a><br>
<a moz-do-not-send="true"
href="http://comments.gmane.org/gmane.comp.compilers.llvm.cvs/161965">http://comments.gmane.org/gmane.comp.compilers.llvm.cvs/161965</a></div>
<div><br>
</div>
<div>Andy, if this patch would be approved can I ask you to
commit it? Neither me nor Jim has commit rights.</div>
<div><br>
</div>
<div>Best,</div>
<div>Ivan.</div>
<div>
<div apple-content-edited="true">
</div>
<br>
<div>
<div>On 13 марта 2014 г., at 21:45, Kaylor, Andrew <<a
moz-do-not-send="true"
href="mailto:andrew.kaylor@intel.com">andrew.kaylor@intel.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<div link="blue" vlink="purple" style="font-family:
Helvetica; font-size: 12px; font-style: normal;
font-variant: normal; font-weight: normal;
letter-spacing: normal; line-height: normal; orphans:
auto; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal; widows:
auto; word-spacing: 0px; -webkit-text-stroke-width:
0px;" lang="EN-US">
<div class="WordSection1" style="page: WordSection1;">
<div style="margin: 0in 0in 0.0001pt; font-size:
12pt; font-family: 'Times New Roman', serif;"><span
style="font-size: 11pt; font-family: Calibri,
sans-serif; color: rgb(31, 73, 125);">That looks
good as an intermediate fix.<o:p></o:p></span></div>
<div style="margin: 0in 0in 0.0001pt; font-size:
12pt; font-family: 'Times New Roman', serif;"><span
style="font-size: 11pt; font-family: Calibri,
sans-serif; color: rgb(31, 73, 125);"> </span></div>
<div style="margin: 0in 0in 0.0001pt; font-size:
12pt; font-family: 'Times New Roman', serif;"><span
style="font-size: 11pt; font-family: Calibri,
sans-serif; color: rgb(31, 73, 125);">In the
long term I think the GDB registration should
probably be moved out of RuntimeDyldELF (maybe
to an event listener), but these changes would
probably be nice to have even then.<o:p></o:p></span></div>
<div style="margin: 0in 0in 0.0001pt; font-size:
12pt; font-family: 'Times New Roman', serif;"><span
style="font-size: 11pt; font-family: Calibri,
sans-serif; color: rgb(31, 73, 125);"> </span></div>
<div style="margin: 0in 0in 0.0001pt; font-size:
12pt; font-family: 'Times New Roman', serif;"><span
style="font-size: 11pt; font-family: Calibri,
sans-serif; color: rgb(31, 73, 125);">-Andy<o:p></o:p></span></div>
<div style="margin: 0in 0in 0.0001pt; font-size:
12pt; font-family: 'Times New Roman', serif;"><span
style="font-size: 11pt; font-family: Calibri,
sans-serif; color: rgb(31, 73, 125);"> </span></div>
<div>
<div style="border-style: solid none none;
border-top-color: rgb(181, 196, 223);
border-top-width: 1pt; padding: 3pt 0in 0in;">
<div style="margin: 0in 0in 0.0001pt; font-size:
12pt; font-family: 'Times New Roman', serif;"><b><span
style="font-size: 10pt; font-family:
Tahoma, sans-serif;">From:</span></b><span
style="font-size: 10pt; font-family: Tahoma,
sans-serif;"><span
class="Apple-converted-space"> </span><a
moz-do-not-send="true"
href="mailto:llvm-commits-bounces@cs.uiuc.edu"
style="color: purple; text-decoration:
underline;">llvm-commits-bounces@cs.uiuc.edu</a><span
class="Apple-converted-space"> </span>[<a
moz-do-not-send="true"
href="mailto:llvm-commits-bounces@cs.uiuc.edu"
style="color: purple; text-decoration:
underline;">mailto:llvm-commits-bounces@cs.uiuc.edu</a>]<span
class="Apple-converted-space"> </span><b>On
Behalf Of<span
class="Apple-converted-space"> </span></b>Ivan
Puzyrevskiy<br>
<b>Sent:</b><span
class="Apple-converted-space"> </span>Thursday,
March 13, 2014 4:45 AM<br>
<b>To:</b><span
class="Apple-converted-space"> </span><a
moz-do-not-send="true"
href="mailto:llvm-commits@cs.uiuc.edu"
style="color: purple; text-decoration:
underline;">llvm-commits@cs.uiuc.edu</a><br>
<b>Cc:</b><span
class="Apple-converted-space"> </span><a
moz-do-not-send="true"
href="mailto:jim.kearney@oracle.com"
style="color: purple; text-decoration:
underline;">jim.kearney@oracle.com</a><br>
<b>Subject:</b><span
class="Apple-converted-space"> </span>[PATCH]
Make GDBJITRegistrar thread-safe<o:p></o:p></span></div>
</div>
</div>
<div style="margin: 0in 0in 0.0001pt; font-size:
12pt; font-family: 'Times New Roman', serif;"><o:p> </o:p></div>
<div>
<div style="margin: 0in 0in 0.0001pt; font-size:
12pt; font-family: 'Times New Roman', serif;"><span
style="font-size: 10pt;">Hi there.<br>
<br>
While investigating a crash in GDBJITRegistrar
I have stumbled upon<span
class="Apple-converted-space"> </span><a
moz-do-not-send="true"
href="http://llvm.org/bugs/show_bug.cgi?id=15750"
style="color: purple; text-decoration:
underline;">http://llvm.org/bugs/show_bug.cgi?id=15750</a><span
class="Apple-converted-space"> </span>. In
my setting there were multiple instances of
MCJIT operating in different threads.<br>
<br>
Patch from Bugzilla applies cleanly and solves
the issue. I have attached a patch against
r203780, yet full credit goes to Jim Kearney (<a
moz-do-not-send="true"
href="mailto:jim.kearney@oracle.com"
style="color: purple; text-decoration:
underline;">jim.kearney@oracle.com</a>),
original author of the patch.<br>
<br>
Any chances to see this in the trunk or 3.5
release?<br>
<br>
Best,<span class="Apple-converted-space"> </span><br>
Ivan<o:p></o:p></span></div>
</div>
<div>
<div style="margin: 0in 0in 0.0001pt; font-size:
12pt; font-family: 'Times New Roman', serif;"><span
style="font-size: 10pt;">_______________________________________________<br>
llvm-commits mailing list<br>
<a moz-do-not-send="true"
href="mailto:llvm-commits@cs.uiuc.edu"
style="color: purple; text-decoration:
underline;">llvm-commits@cs.uiuc.edu</a><br>
<a moz-do-not-send="true"
href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits"
style="color: purple; text-decoration:
underline;">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></span></div>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>