<div dir="ltr">Can you move this<div><br></div><div>bool is64BitFP = (CMP00.getValueType() == MVT::f64);<br></div><div><br></div><div>to be below the AVX512 code since that path doesn't need it. Otherwise LGTM.</div></div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Mar 10, 2014 at 6:21 PM, Hans Wennborg <span dir="ltr"><<a href="mailto:hans@chromium.org" target="_blank">hans@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class=""><br>
On Mon, Mar 10, 2014 at 6:18 PM, Craig Topper <<a href="mailto:craig.topper@gmail.com">craig.topper@gmail.com</a>> wrote:<br>
> Is there an earlier check to ensure SSE2 is supported? Just want to make<br>
> sure we have everything covered.<br>
<br>
</div> Yup, we basically check on entry to the CMPEQCombine function.<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D3009" target="_blank">http://llvm-reviews.chandlerc.com/D3009</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>~Craig
</div>