<HTML><HEAD><TITLE>Samsung Enterprise Portal mySingle</TITLE>
<META content=IE=5 http-equiv=X-UA-Compatible>
<META content="text/html; charset=windows-1252" http-equiv=Content-Type>
<STYLE id=mysingle_style type=text/css>P {
MARGIN-BOTTOM: 5px; FONT-SIZE: 9pt; FONT-FAMILY: Arial, arial; MARGIN-TOP: 5px
}
TD {
MARGIN-BOTTOM: 5px; FONT-SIZE: 9pt; FONT-FAMILY: Arial, arial; MARGIN-TOP: 5px
}
LI {
MARGIN-BOTTOM: 5px; FONT-SIZE: 9pt; FONT-FAMILY: Arial, arial; MARGIN-TOP: 5px
}
BODY {
FONT-SIZE: 9pt; FONT-FAMILY: Arial, arial; MARGIN: 10px; LINE-HEIGHT: 1.4
}
</STYLE>
<META name=GENERATOR content=ActiveSquare></HEAD>
<BODY>
<P>Hi Reid,</P>
<P> </P>
<P>I have attached a separate binary patch for bc file. This is same file attached in bug report. I have added llvm-bcanalyzer as comment in test case. But I do not understand much of it.</P>
<P> </P>
<P>I have updated my fix a bit. I have update dyn_cast to dyn_cast_or_null for all location casting values from ValueList to something. If code was already returning some error code on null value, I left them as it is. For other cases, I have added null check and on null it will return "InvalidValue".</P>
<P> </P>
<P>Regards</P>
<P>Dinesh Dwivedi</P>
<P> </P>
<P> </P>
<P> </P>
<P> </P>
<P>------- <B>Original Message</B> -------</P>
<P><B>Sender</B> : Reid Kleckner<rnk@google.com></P>
<P><B>Date</B> : Feb 27, 2014 00:16 (GMT+05:30)</P>
<P><B>Title</B> : Re: [PATCH] Fix for bitcode reader crash on invalid input [PR18704]</P>
<P> </P>
<DIV dir=ltr>The binary content of the .bc file isn't present in the diff. Can you attach it, and maybe paste the output of llvm-bcanalyzer into the test case as a comment? Also, the fix doesn't look correct. It looks like subsequent Arguments might leak, although that isn't really critical.</DIV>
<DIV class=gmail_extra><BR><BR>
<DIV class=gmail_quote>On Wed, Feb 26, 2014 at 7:37 AM, Dinesh Dwivedi <SPAN dir=ltr><<A href="mailto:dinesh.d@samsung.com" target=_blank>dinesh.d@samsung.com</A>></SPAN> wrote:<BR>
<BLOCKQUOTE class=gmail_quote style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">Attaching patch for PR18704. I have just gone through back-trace for the assert [dyn_cast was getting applied to NULL value], locate code causing this and added check to print error for NULL values.<BR><BR>Regards<BR><SPAN class=HOEnZb><FONT color=#888888>Dinesh Dwivedi<BR><BR></FONT></SPAN><BR>_______________________________________________<BR>llvm-commits mailing list<BR><A href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</A><BR><A href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target=_blank>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</A><BR><BR></BLOCKQUOTE></DIV><BR></DIV>
<P> </P>
<P> </P>
<P> </P>
<TABLE id=confidentialsignimg>
<TBODY>
<TR>
<TD NAMO_LOCK>
<P><IMG border=0 src="cid:Z5JE7EUABGFC@namo.co.kr" width=520></P></TD></TR></TBODY></TABLE></BODY></HTML><img src='http://ext.samsung.net/mailcheck/SeenTimeChecker?do=71399b4f824fe3ca56788410ab3e5c0062b74e4e43059deeef6b516eedac67389e881b09962f7767598ef4afaea8dfc718066911c76275ea08cece8541bc14eacf878f9a26ce15a0' border=0 width=0 height=0 style='display:none'>