<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Feb 25, 2014, at 5:07 PM, Quentin Colombet <<a href="mailto:qcolombet@apple.com">qcolombet@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div style="margin: 0px 0px 0px 4px;">Hi Adam,</div><div style="margin: 0px 0px 0px 4px;"><br></div><div style="margin: 0px 0px 0px 4px;">This LGTM with two comments:</div></div></blockquote><div><br></div><div>Hi Quentin,</div><div><br></div><div>Thanks very much for the review.</div><br><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div style="margin: 0px 0px 0px 4px;"><br></div><div style="margin: 0px 0px 0px 4px;">1. Could you add a comment on why this is not useful for AVX?</div><div style="margin: 0px 0px 0px 4px;"> + if (Subtarget->hasAVX())</div><div style="margin: 0px 0px 0px 4px;"> + break;</div></div></blockquote><div><br></div><div>Done.</div><br><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div style="margin: 0px 0px 0px 4px;"><br></div><div style="margin: 0px 0px 0px 4px;">2. As it is your CHECK-LABEL lines may cause failure on pecoff target, see r201931 on how to fix that.</div></div></blockquote><div><br></div><div>Added colon after the label name and -mtriple to the command line.</div><div><br></div><div>New version is attached including the check-in message. Please apply it for me, thank you.</div><div><br></div><div>Adam</div><div><br></div><div></div></div></body></html>