<div dir="ltr">Clang doesn't warn here. Small repro:<div><br><div><div>$ cat tmp/warning/a.cc</div><div>#include <cassert></div><div>bool x;</div><div>int val;</div><div>void foo() {</div><div>  assert(x && val == 4 || (!x && val == 5));</div>
<div>}</div></div><div><br></div><div><div>$ gcc-4.8.2-inst/bin/g++ -c tmp/warning/a.cc -Wall -o a.o</div><div>In file included from /gcc-4.8.2-inst/include/c++/4.8.2/cassert:43:0,</div><div>                 from tmp/warning/a.cc:1:</div>
<div>tmp/warning/a.cc: In function ‘void foo()’:</div><div>tmp/warning/a.cc:5:12: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]</div><div>   assert(x && val == 4 || (!x && val == 5));</div>
<div>            ^</div></div><div>$ ./bin/clang++ -c tmp/warning/a.cc -Wall -o a.o</div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Feb 25, 2014 at 8:55 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Did clang not catch this? Should it have?</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra">
<br><br><div class="gmail_quote">On Mon, Feb 24, 2014 at 11:56 PM, Alexey Samsonov <span dir="ltr"><<a href="mailto:samsonov@google.com" target="_blank">samsonov@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: samsonov<br>
Date: Tue Feb 25 01:56:00 2014<br>
New Revision: 202119<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=202119&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=202119&view=rev</a><br>
Log:<br>
Silence GCC warning<br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/Scalar/SROA.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/Scalar/SROA.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/SROA.cpp?rev=202119&r1=202118&r2=202119&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/SROA.cpp?rev=202119&r1=202118&r2=202119&view=diff</a><br>


==============================================================================<br>
--- llvm/trunk/lib/Transforms/Scalar/SROA.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Scalar/SROA.cpp Tue Feb 25 01:56:00 2014<br>
@@ -2448,7 +2448,7 @@ private:<br>
     uint64_t NewEndOffset = std::min(EndOffset, NewAllocaEndOffset);<br>
<br>
     bool IsDest = &II.getRawDestUse() == OldUse;<br>
-    assert(IsDest && II.getRawDest() == OldPtr ||<br>
+    assert((IsDest && II.getRawDest() == OldPtr) ||<br>
            (!IsDest && II.getRawSource() == OldPtr));<br>
<br>
     // Compute the relative offset within the transfer.<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Alexey Samsonov, MSK</div>
</div>