<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 02/19/2014 04:44 PM, Eric
Christopher wrote:<br>
</div>
<blockquote
cite="mid:CALehDX7CuaQur0fArx3vb0kzEuFFe0o_W=nrmWMQT_6kehoiKg@mail.gmail.com"
type="cite">
<pre wrap="">The comment should be fine, you don't need to leave the commented out
code in there.
-eric</pre>
</blockquote>
<i> </i>I want that code put in there when the issue is fixed in
MipsAsmPrinter.<br>
If I delete it then I, or someone else, needs to re-figure out the
right incantation.<br>
<br>
If the stub does not need help returning then it does not need to
save S2.<br>
But to support that, Asm printer needs to generate a different kind
of call.<br>
<br>
If I used raw text I would just generate it but that is not allowed
anymore so I need to create<br>
MipsMCExpr and add some special methods to do that. I did not want
to make an already<br>
large patch larger by adding it.<br>
<br>
Reed<br>
<br>
<br>
<blockquote
cite="mid:CALehDX7CuaQur0fArx3vb0kzEuFFe0o_W=nrmWMQT_6kehoiKg@mail.gmail.com"
type="cite">
<pre wrap="">
On Wed, Feb 19, 2014 at 2:59 PM, reed kotler <a class="moz-txt-link-rfc2396E" href="mailto:rkotler@mips.com"><rkotler@mips.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Here is a proposed patch then:
rkotler@mipssw006:~/llvm_trunk$ svn diff
Index: lib/Target/Mips/Mips16ISelLowering.cpp
===================================================================
--- lib/Target/Mips/Mips16ISelLowering.cpp (revision 201723)
+++ lib/Target/Mips/Mips16ISelLowering.cpp (working copy)
@@ -467,8 +467,11 @@
// So for now we always save S2. The optimization will be done
// in a follow-on patch.
//
- if (1 || (Signature->RetSig != Mips16HardFloatInfo::NoFPRet))
- FuncInfo->setSaveS2();
+ // FIXME: add this conditional when optimization to not save S2
+ // can be satisfied by AsmPrinter.
+ //
+ // if (Signature->RetSig != Mips16HardFloatInfo::NoFPRet)
+ FuncInfo->setSaveS2();
}
// one more look at list of intrinsics
if (std::binary_search(Mips16IntrinsicHelper,
On 02/19/2014 02:35 PM, Eric Christopher wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
Uh, this is just if (true)... how about just put a FIXME in there and
remove the conditional?
-eric
On Wed, Feb 19, 2014 at 2:11 PM, Reed Kotler <a class="moz-txt-link-rfc2396E" href="mailto:rkotler@mips.com"><rkotler@mips.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
Author: rkotler
Date: Wed Feb 19 16:11:45 2014
New Revision: 201723
URL: <a class="moz-txt-link-freetext" href="http://llvm.org/viewvc/llvm-project?rev=201723&view=rev">http://llvm.org/viewvc/llvm-project?rev=201723&view=rev</a>
Log:
Make one statement easier to understand from post commmit feedback from a
review of the previous patch that introduced this week.
Modified:
llvm/trunk/lib/Target/Mips/Mips16ISelLowering.cpp
Modified: llvm/trunk/lib/Target/Mips/Mips16ISelLowering.cpp
URL:
<a class="moz-txt-link-freetext" href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/Mips16ISelLowering.cpp?rev=201723&r1=201722&r2=201723&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/Mips16ISelLowering.cpp?rev=201723&r1=201722&r2=201723&view=diff</a>
==============================================================================
--- llvm/trunk/lib/Target/Mips/Mips16ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/Mips/Mips16ISelLowering.cpp Wed Feb 19 16:11:45
2014
@@ -467,7 +467,7 @@ getOpndList(SmallVectorImpl<SDValue> &Op
// So for now we always save S2. The optimization will be
done
// in a follow-on patch.
//
- if (Signature->RetSig != Mips16HardFloatInfo::NoFPRet || 1)
+ if (1 || (Signature->RetSig != Mips16HardFloatInfo::NoFPRet))
FuncInfo->setSaveS2();
}
// one more look at list of intrinsics
_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
</blockquote>
<br>
</body>
</html>