<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">LGTM. <div><br><div style=""><div>On Feb 18, 2014, at 8:54 AM, Eli Bendersky <<a href="mailto:eliben@google.com">eliben@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Ping!<br><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Feb 13, 2014 at 10:27 AM, Eli Bendersky <span dir="ltr"><<a href="mailto:eliben@google.com" target="_blank">eliben@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">The same code (~20 lines) for initializing a TargetOptions object from CodeGen cmdline flags is duplicated 4 (yes 4) times in 4 different tools. This patch moves it into a utility function.<div>
<br></div><div>
Since the CodeGen/CommandFlags.h file defines cl::opt flags *in a header*, it's a bit of a touchy situation because we should only link them into tools. So this patch puts the init function in the header. Ideas for something better are most welcome!</div>
<div><br></div><div>PTAL</div><span class="HOEnZb"><font color="#888888">Eli</font></span></div>
</blockquote></div><br></div></div>
_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br></div></body></html>