<html>
<head>
<meta content="text/html; charset=GB2312" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">
<meta http-equiv="content-type" content="text/html;
charset=GB2312">
<pre class="bz_comment_text" id="comment_text_2" style="font-size: small; font-family: monospace; white-space: pre-wrap; width: 50em; color: rgb(0, 0, 0); font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255);">And here is my test case.This test case has been posted in
<a class="moz-txt-link-freetext" href="http://llvm.org/bugs/show_bug.cgi?id=18833">http://llvm.org/bugs/show_bug.cgi?id=18833</a>
cat 1.s
.thumb
_foo:
OBJECT .req r2
mov r4, OBJECT
mov r4, oBjEcT
.unreq OBJECT
_foo2:
OBJECT .req r5
mov r4, OBJECT
.unreq OBJECT
bin/clang -target arm-linux-androideabi -march=armv7-a -c 1.s
1.s:12:15: error: redefinition of 'object' does not match original.
OBJECT .req r5</pre>
<br>
By the way manjian is me.<br>
<br>
于 2014年02月18日 10:25, Duncan P. N. Exon Smith 写道:<br>
</div>
<blockquote
cite="mid:B167B93C-D67E-4BDA-A1DA-89ACE594CEA4@apple.com"
type="cite">
<pre wrap="">On 2014 Feb 17, at 17:50, lin zuojian <a class="moz-txt-link-rfc2396E" href="mailto:manjian2006@gmail.com"><manjian2006@gmail.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">It's weird to see a test case already lies in test/MC/ARM/dot-req.s and
should show this problem.Here is my patch:
</pre>
</blockquote>
<pre wrap="">
Hi Lin,
I just had a look at test/MC/ARM/dot-req.s, and I don’t see any capitalized
names sent to .req. Certainly, before this can be committed you need to find a
testcase that fails without your change and passes with it.
It looks like the one manjian posted to PR18833 is a good start.
Duncan
f
</pre>
<blockquote type="cite">
<pre wrap="">
Index: lib/Target/ARM/AsmParser/ARMAsmParser.cpp
===================================================================
--- lib/Target/ARM/AsmParser/ARMAsmParser.cpp (revision 201500)
+++ lib/Target/ARM/AsmParser/ARMAsmParser.cpp (working copy)
@@ -8243,7 +8243,7 @@
Error(L, "unexpected input in .unreq directive.");
return false;
}
- RegisterReqs.erase(Parser.getTok().getIdentifier());
+ RegisterReqs.erase(Parser.getTok().getIdentifier().lower());
Parser.Lex(); // Eat the identifier.
return false;
}
---
lin zuojian
_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
<br>
</body>
</html>