<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:799957587;
mso-list-type:hybrid;
mso-list-template-ids:-1214880770 44585902 67698691 67698693 67698689 67698691 67698693 67698689 67698691 67698693;}
@list l0:level1
{mso-level-start-at:0;
mso-level-number-format:bullet;
mso-level-text:-;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:"Calibri","sans-serif";
mso-fareast-font-family:"Times New Roman";}
@list l0:level2
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:"Courier New";}
@list l0:level3
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;}
@list l0:level4
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Symbol;}
@list l0:level5
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:"Courier New";}
@list l0:level6
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;}
@list l0:level7
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Symbol;}
@list l0:level8
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:"Courier New";}
@list l0:level9
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;}
ol
{margin-bottom:0cm;}
ul
{margin-bottom:0cm;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I still have this problem:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">/lib/IR/Dominators.cpp:68: error: using
</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">‘</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">typename</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">’</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">
outside of template<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">/lib/IR/Dominators.cpp:71: error: using
</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">‘</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">typename</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">’</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">
outside of template<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal" style="margin-left:36.0pt;text-indent:-18.0pt;mso-list:l0 level1 lfo1">
<![if !supportLists]><span style="font-family:"Calibri","sans-serif";color:#31849B"><span style="mso-list:Ignore">-<span style="font:7.0pt "Times New Roman"">
</span></span></span><![endif]><span dir="LTR"></span><b><i><span style="color:#31849B"> Elena<o:p></o:p></span></i></b></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> llvm-commits-bounces@cs.uiuc.edu [mailto:llvm-commits-bounces@cs.uiuc.edu]
<b>On Behalf Of </b>David Blaikie<br>
<b>Sent:</b> Saturday, February 15, 2014 02:41<br>
<b>To:</b> Lang Hames<br>
<b>Cc:</b> Commit Messages and Patches for LLVM<br>
<b>Subject:</b> Re: [llvm] r201440 - Add extern template instantiations of llvm::Calculate.<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Hopefully fixed by removing the unnecessary 'typename' in r201450.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On Fri, Feb 14, 2014 at 4:34 PM, Lang Hames <<a href="mailto:lhames@gmail.com" target="_blank">lhames@gmail.com</a>> wrote:<o:p></o:p></p>
<p class="MsoNormal">Hi Rafael,<br>
<br>
My compiler is warning on this patch: "'typename' occurs outside of a<br>
template [-W++11-extensions]".<br>
<br>
This may need to be reverted until we make the switch to C++11.<br>
<br>
Cheers,<br>
Lang.<o:p></o:p></p>
<div>
<div>
<p class="MsoNormal"><br>
On Fri, Feb 14, 2014 at 2:36 PM, Rafael Espindola<br>
<<a href="mailto:rafael.espindola@gmail.com">rafael.espindola@gmail.com</a>> wrote:<br>
> Author: rafael<br>
> Date: Fri Feb 14 16:36:16 2014<br>
> New Revision: 201440<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=201440&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=201440&view=rev</a><br>
> Log:<br>
> Add extern template instantiations of llvm::Calculate.<br>
><br>
> This should be a small build time improvement in general and fixes<br>
> the build on OS X with -DBUILD_SHARED_LIBS=ON.<br>
><br>
> The issue is that not all users are including GenericDomTreeConstruction.h,<br>
> causing undefined references when ld64 managed to hide the<br>
> linkonce_odr symbols.<br>
><br>
> Modified:<br>
> llvm/trunk/include/llvm/IR/Dominators.h<br>
> llvm/trunk/lib/IR/Dominators.cpp<br>
><br>
> Modified: llvm/trunk/include/llvm/IR/Dominators.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/Dominators.h?rev=201440&r1=201439&r2=201440&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/Dominators.h?rev=201440&r1=201439&r2=201440&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/include/llvm/IR/Dominators.h (original)<br>
> +++ llvm/trunk/include/llvm/IR/Dominators.h Fri Feb 14 16:36:16 2014<br>
> @@ -34,6 +34,17 @@ namespace llvm {<br>
> EXTERN_TEMPLATE_INSTANTIATION(class DomTreeNodeBase<BasicBlock>);<br>
> EXTERN_TEMPLATE_INSTANTIATION(class DominatorTreeBase<BasicBlock>);<br>
><br>
> +#define LLVM_COMMA ,<br>
> +EXTERN_TEMPLATE_INSTANTIATION(<br>
> + void llvm::Calculate<Function LLVM_COMMA BasicBlock *>(<br>
> + DominatorTreeBase<typename GraphTraits<BasicBlock *>::NodeType> &DT<br>
> + LLVM_COMMA Function &F));<br>
> +EXTERN_TEMPLATE_INSTANTIATION(void llvm::Calculate<<br>
> + Function LLVM_COMMA Inverse<BasicBlock *> >(DominatorTreeBase<<br>
> + typename GraphTraits<Inverse<BasicBlock *> >::NodeType> &DT LLVM_COMMA<br>
> + Function &F));<br>
> +#undef LLVM_COMMA<br>
> +<br>
> typedef DomTreeNodeBase<BasicBlock> DomTreeNode;<br>
><br>
> class BasicBlockEdge {<br>
><br>
> Modified: llvm/trunk/lib/IR/Dominators.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Dominators.cpp?rev=201440&r1=201439&r2=201440&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Dominators.cpp?rev=201440&r1=201439&r2=201440&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/IR/Dominators.cpp (original)<br>
> +++ llvm/trunk/lib/IR/Dominators.cpp Fri Feb 14 16:36:16 2014<br>
> @@ -64,6 +64,16 @@ bool BasicBlockEdge::isSingleEdge() cons<br>
> TEMPLATE_INSTANTIATION(class llvm::DomTreeNodeBase<BasicBlock>);<br>
> TEMPLATE_INSTANTIATION(class llvm::DominatorTreeBase<BasicBlock>);<br>
><br>
> +#define LLVM_COMMA ,<br>
> +TEMPLATE_INSTANTIATION(void llvm::Calculate<Function LLVM_COMMA BasicBlock *>(<br>
> + DominatorTreeBase<typename GraphTraits<BasicBlock *>::NodeType> &DT<br>
> + LLVM_COMMA Function &F));<br>
> +TEMPLATE_INSTANTIATION(void llvm::Calculate<<br>
> + Function LLVM_COMMA Inverse<BasicBlock *> >(DominatorTreeBase<<br>
> + typename GraphTraits<Inverse<BasicBlock *> >::NodeType> &DT LLVM_COMMA<br>
> + Function &F));<br>
> +#undef LLVM_COMMA<br>
> +<br>
> // dominates - Return true if Def dominates a use in User. This performs<br>
> // the special checks necessary if Def and User are in the same basic block.<br>
> // Note that Def doesn't dominate a use in Def itself!<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><o:p></o:p></p>
</div>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
<p>---------------------------------------------------------------------<br>
Intel Israel (74) Limited</p>
<p>This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.</p></body>
</html>