<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>I agree. Let’s merge these patches. </div><br><div><div>On Feb 16, 2014, at 4:22 PM, Duncan P. N. Exon Smith <<a href="mailto:dexonsmith@apple.com">dexonsmith@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On 2014 Feb 7, at 07:38, Tom Stellard <<a href="mailto:tom@stellard.net">tom@stellard.net</a>> wrote:<br><br><blockquote type="cite">cc'ing Code Owner Nadav<br><br>On Fri, Feb 07, 2014 at 04:05:18PM +0100, Holger Hoffstätte wrote:<br><blockquote type="cite">[CC:'ed committer as requested]<br><br>On 02/06/14 23:34, Tom Stellard wrote:<br><blockquote type="cite">We are going to try to have a 3.4.1 bugfix release at some point in<br>the future. If there have been any bug fixes merged to ToT since the<br>3.4 release that you would like included in a 3.4.1 release, please<br>email me and cc the code owner with the commit number, and we will work<br>on getting the patch merged into the 3.4 branch.<br></blockquote><br>Tom,<br><br>Thanks a lot for doing this. I helped a bit with getting 3.4 into<br>Gentoo, and one thing we did pretty much immediately was to apply an<br>additional patchset for otherwsie broken vararg handling, which didn't<br>make it into the 3.4.0 release.<br><br>The mailing list thread where the fixes didn't make it:<br><a href="http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20131216/199116.html">http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20131216/199116.html</a><br><br>The list of commits is:<br>http://llvm.org/viewvc/llvm-project?view=revision&revision=197503<br>http://llvm.org/viewvc/llvm-project?view=revision&revision=197505<br>http://llvm.org/viewvc/llvm-project?view=revision&revision=197520<br><br></blockquote><br>I think we would want to squash these patches if we merged them into the 3.4<br>tree. Duncan, Nadav what do you think? Are these patches OK to merge?<br><br>-Tom<br></blockquote><br>Hi Tom, Holger,<br><br>I agree that these should go in the release branch. Varargs are rather<br>important. Also, squashing them makes sense.<br><br>Cheers,<br>Duncan<br><br><blockquote type="cite"><blockquote type="cite">The Gentoo bug with all the information in one place, for reference:<br><a href="https://bugs.gentoo.org/show_bug.cgi?id=497298">https://bugs.gentoo.org/show_bug.cgi?id=497298</a><br><br>Thanks!<br><br>Holger</blockquote></blockquote></div></blockquote></div><br></body></html>